Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sanity): fixing flaky sanity test case #256

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Conversation

pawanpraka1
Copy link
Contributor

@pawanpraka1 pawanpraka1 commented Dec 10, 2020

flaky sanity fix and updated the docker image to 18.04 for github action, missed adding this in the PR #255.

Signed-off-by: Pawan pawan@mayadata.io

@pawanpraka1 pawanpraka1 added the bug Something isn't working. label Dec 10, 2020
@pawanpraka1 pawanpraka1 added this to the v1.2.0 milestone Dec 10, 2020
Copy link
Member

@prateekpandey14 prateekpandey14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, even we can think of moving to ubuntu 20.04 which more optimized container image in coming future ?

@pawanpraka1
Copy link
Contributor Author

@prateekpandey14 we did that and faced mount related issue with 20,04 so reverted back to 19.10. If that is stable, we can move to it.

Also moving to bionic docker image for github action also.

Signed-off-by: Pawan <pawan@mayadata.io>
@pawanpraka1 pawanpraka1 changed the title feat(image): moving to bionic docker image for github action fix(sanity): fixing flaky sanity test case Dec 10, 2020
@codecov-io
Copy link

Codecov Report

Merging #256 (22764e3) into master (2ae14f5) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #256      +/-   ##
=========================================
- Coverage    7.80%   7.70%   -0.10%     
=========================================
  Files          20      20              
  Lines        1141    1155      +14     
=========================================
  Hits           89      89              
- Misses       1051    1065      +14     
  Partials        1       1              
Impacted Files Coverage Δ
pkg/driver/controller.go 0.64% <0.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ae14f5...22764e3. Read the comment docs.

@kmova kmova merged commit 0409fca into openebs:master Dec 10, 2020
ZFS Local PV automation moved this from In progress to Done Dec 10, 2020
2.4 Release Tracker - Due Dec 15th. automation moved this from RC1 - Due: Dec 5 2020 to Done Dec 10, 2020
@pawanpraka1 pawanpraka1 deleted the image branch December 14, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
ZFS Local PV
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants