Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(localpv): Update examples to use recordsize=128k #458

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

aceat64
Copy link
Contributor

@aceat64 aceat64 commented Jul 12, 2023

Why is this PR required? What issue does it fix?:

The default recordsize for ZFS datasets is 128k, and significantly better for most use-cases than 4k as shown in the StorageClass examples. Any users who copy the examples may see substantial performance hits and fragmentation in their datasets.

What this PR does?:

Updates the StorageClass examples to set a recordsize of 128k instead of 4k.

Does this PR require any upgrade changes?:

No, this is a documentation change only.

If the changes in this PR are manually verified, list down the scenarios covered::
n/a?

Any additional information for your reviewer? :
No

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

This is the default recordsize for ZFS datasets, and significantly better for most use-cases than 4k.

Signed-off-by: Andrew LeCody <andrew@beyondweb.net>
@niladrih
Copy link
Member

Hi @aceat64, thank you for this!

@niladrih niladrih merged commit 35e06fd into openebs:develop Jul 22, 2023
1 check passed
jnels124 pushed a commit to jnels124/zfs-localpv that referenced this pull request Jul 26, 2023
This is the default recordsize for ZFS datasets, and significantly better for most use-cases than 4k.

Signed-off-by: Andrew LeCody <andrew@beyondweb.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants