feat(crd-gen): automate the CRDs generation with validations for APIs #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanpraka1
reviewed
Apr 1, 2020
- To generate the CRD spec `make manifest` generate then under deploy/crds directory - added a update-crd script to automate the steps to generate CRDs and its validation of each types Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
prateekpandey14
force-pushed
the
add-gen-crd
branch
from
2e1d048
to
bf2fc5d
Compare
Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=======================================
Coverage 23.57% 23.57%
=======================================
Files 14 14
Lines 475 475
=======================================
Hits 112 112
Misses 362 362
Partials 1 1 Continue to review full report at Codecov.
|
pawanpraka1
reviewed
Apr 1, 2020
pawanpraka1
reviewed
Apr 1, 2020
pawanpraka1
reviewed
Apr 1, 2020
Signed-off-by: prateekpandey14 <prateek.pandey@mayadata.io>
pawanpraka1
added this to Pre-commits and Designs - Due: Mar 31st 2020
in 1.9 Release Tracker - Due Apr 15th.
|
thanks @prateekpandey14 for this PR. |
1.9 Release Tracker - Due Apr 15th.
automation
moved this from Pre-commits and Designs - Due: Mar 31st 2020
to Done
Apr 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make manifestgenerate then underdeploy/crds directory
Signed-off-by: prateekpandey14 prateek.pandey@mayadata.io