Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

feanil/fix codecov #431

Merged
merged 2 commits into from
Apr 18, 2023
Merged

feanil/fix codecov #431

merged 2 commits into from
Apr 18, 2023

Conversation

feanil
Copy link
Contributor

@feanil feanil commented Apr 13, 2023

  • build: Don't install codecov as a dependency.
  • chore: Run make upgrade.

Feanil Patel added 2 commits April 13, 2023 11:07
We use the github action to do uploads now so we don't need it in ci.in
or ci.txt

Explicitly install coverage so we can generate coverage info during
tests.
@feanil feanil requested a review from UsamaSadiq April 13, 2023 15:38
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bb1cbe4) 86.55% compared to head (d583d6e) 86.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #431   +/-   ##
=======================================
  Coverage   86.55%   86.55%           
=======================================
  Files          11       11           
  Lines         952      952           
  Branches      156      156           
=======================================
  Hits          824      824           
  Misses         85       85           
  Partials       43       43           
Flag Coverage Δ
unittests 86.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@feanil feanil merged commit 4b0c30d into master Apr 18, 2023
@feanil feanil deleted the feanil/fix_codecov branch April 18, 2023 12:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants