This repository has been archived by the owner on May 1, 2024. It is now read-only.
Enrollment tracks: add credit, do not merge audit & honor #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -255,7 +256,7 @@ def handle(self, *args, **options): | |||
| username = options['username'] | |||
| video_id = '0fac49ba' | |||
| video_module_id = 'i4x-edX-DemoX-video-5c90cffecd9b48b188cbfea176bf7fe9' | |||
| start_date = datetime.datetime(year=2015, month=1, day=1, tzinfo=timezone.utc) | |||
| start_date = datetime.datetime(year=2016, month=1, day=1, tzinfo=timezone.utc) | |||
|
Nice! More code was deleted than added. :) I tested this out and it looks great! 👍 What do you think about holding off merging it until the learner analytics beta gets out in the next few days? |
|
@dsjen That sounds like a good idea. It would be nice to wait and synchronize this merge with an insights one that propagates these changes to the front-end too. |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our enrollment tracks on the API side to match what we are communicating elsewhere.
@dsjen, let me know if this is or isn't what you are expecting to work with in insights.
@dsjen @ajpal