New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup #474
base: main
Are you sure you want to change the base?
chore: cleanup #474
Conversation
Thanks for the pull request, @CodeWithEmad! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Also, the |
I'm willing to review this, but the build failed. |
85cde77
to
e8c1ec8
Compare
Thanks @pdpinch |
Yikes! I'm gonna let @pdpinch review this, but I'll jump in if needed. @CodeWithEmad - for future cleanups, it'd be preferable if you could split into smaller pull requests and/or commits. It may take a long time to review this, and require some painful rebasing. |
For sure @sarina. |
Definitely don't turn it down, I love the changes! I really appreciate you making them. Ways you can consider splitting it up would be do only a group of files at a time (ie only the release notes files, then only the course ops ones, etc), or splitting out different types of changes (ie one PR that only does trailing whitespace, another PR that is just fixing header definitions, etc). |
Indeed, I haven't gotten very far with this yet. If you have some time to break it into smaller, section-based PRs, that would be motivating and help us get it merged faster.
|
Sure, I'll try to break it into smaller commits. |
e8c1ec8
to
7caf5b0
Compare
I'll move other changes to different PRs. |
7caf5b0
to
944ba86
Compare
@CodeWithEmad does this PR need to be reviewed, or was it replaced by #481 and #482 ? |
Yes, it can use a review, @pdpinch. |
944ba86
to
df11a0f
Compare
I was just reading the docs and noticed a typo. went to fix that, and found another one and another one. After a couple of hours, I found myself cleaning up most of the documentation 馃ぃ
I know reviewing might be painful, but look at the bright side, we will have much much cleaner documentation in the future.
This will introduce: