Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixed typos #482

Merged
merged 2 commits into from Apr 15, 2024
Merged

chore: fixed typos #482

merged 2 commits into from Apr 15, 2024

Conversation

CodeWithEmad
Copy link
Contributor

As decided in #474, I'll break the big clean-up PR into smaller PRs for faster review/merge.

this will introduce:

  • fixing typos.
  • fixing code block usage.

@openedx-webhooks
Copy link

Thanks for the pull request, @CodeWithEmad! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 28, 2024
@feanil
Copy link
Contributor

feanil commented Mar 29, 2024

@CodeWithEmad this has some conflicts with your other PR that I merged, can you fix it up?

@CodeWithEmad
Copy link
Contributor Author

Sure @feanil.

Copy link
Contributor

@pdpinch pdpinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this @CodeWithEmad! It really improves the quality of the docs, and I appreciate the fixes to my own typos 😳.

I left a couple of comments to fix up the grammar in a few places and a couple of nits that you can take or leave.

I have one style question that I'd like a second opinion on, maybe from @feanil. The existing docs often include a shell prompt ($) in code snippets, and this PR removes them. I think it's an improvement, but we should check on what is the common practice.

@CodeWithEmad
Copy link
Contributor Author

CodeWithEmad commented Apr 1, 2024

Thank you @pdpinch for the review. I've added all the requested changes.

The existing docs often include a shell prompt ($) in code snippets, and this PR removes them.

The code blocks have a copy button in the website. Having the $ in the beginning causes unnecessary deletion for users who want to copy and use that command.

Copy link
Contributor

@pdpinch pdpinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'm comfortable merging this, but I had one last question for @feanil -- do the 2 commits need to be squashed, or can I do a rebase and merge them? (There doesn't seem to be any commit linting in this repo, but I think they each pass conventional commits)

@feanil
Copy link
Contributor

feanil commented Apr 8, 2024

You can rebase merge, I only squash when it's clear there are a lot of intermediate temp commits. We turned off conventional commits on this repo to make it easier for less technical folks to make suggestions without needing to understand conventional commits.

@pdpinch pdpinch merged commit 3214e0a into openedx:main Apr 15, 2024
2 checks passed
@openedx-webhooks
Copy link

@CodeWithEmad 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@pdpinch
Copy link
Contributor

pdpinch commented Apr 15, 2024

Thank you @CodeWithEmad!

@pdpinch pdpinch mentioned this pull request Apr 15, 2024
@CodeWithEmad CodeWithEmad deleted the chore/typo branch April 15, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants