feat!: make forgiving JWTs the default #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robrap
commented
Nov 8, 2023
This was referenced Nov 8, 2023
robrap
force-pushed
the
robrap/remove-forgiven-jwt-toggle
branch
from
bf5ae92
to
26cac08
Compare
feanil
approved these changes
Nov 20, 2023
robrap
force-pushed
the
robrap/remove-forgiven-jwt-toggle
branch
from
26cac08
to
27f789a
Compare
feanil
approved these changes
Nov 28, 2023
robrap
commented
Nov 28, 2023
robrap
force-pushed
the
robrap/remove-forgiven-jwt-toggle
branch
from
044ea74
to
7014a0d
Compare
feanil
approved these changes
Dec 19, 2023
robrap
force-pushed
the
robrap/remove-forgiven-jwt-toggle
branch
from
8fc82f3
to
c82ad02
Compare
This is the final step (in this library) of the rollout of forgiving JWTs as a replacement for the USE-JWT-COOKIE header. **BREAKING CHANGE:** Removed ENABLE_FORGIVING_JWT_COOKIES toggle. It is now permanently enabled. - The header USE-JWT-COOKIE was removed because it has been fully replaced by forgiving JWTs. - Removed temporary rollout custom attributes: use_jwt_cookie_requested, jwt_auth_request_user_not_found, and skip_jwt_vs_session_check. See ADR 0002-remove-use-jwt-cookie-header.rst for details.
robrap
force-pushed
the
robrap/remove-forgiven-jwt-toggle
branch
from
c82ad02
to
7d931d2
Compare
|
@feanil: [request] This is ready for review again. I squashed the earlier commits and rebased again. Reviewing by commit just doesn't work. I did find that reviewing without whitespace makes it pretty simple to see changes: https://github.com/openedx/edx-drf-extensions/pull/404/files?diff=unified&w=1. |
feanil
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is the final step (in this library) of the rollout of forgiving JWTs as a replacement for the USE-JWT-COOKIE header.
BREAKING CHANGE: Removed ENABLE_FORGIVING_JWT_COOKIES toggle. It is now permanently enabled.
See ADR 0002-remove-use-jwt-cookie-header.rst for details.
Reviewers:
Merge checklist:
Post merge:
finished.