feat: add check for enforcing jwt and lms user email match #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robrap
reviewed
Dec 20, 2023
syedsajjadkazmii
force-pushed
the
sajjad/VAN-1694
branch
6 times, most recently
from
29154d4
to
c74c3e4
Compare
robrap
reviewed
Jan 5, 2024
I will update the changelog and version once my branch is rebased on the master. If it's okay. |
robrap
force-pushed
the
robrap/remove-forgiven-jwt-toggle
branch
from
c82ad02
to
7d931d2
Compare
robrap
reviewed
Jan 10, 2024
edx_rest_framework_extensions/auth/jwt/tests/test_authentication.py
Outdated
Show resolved
Hide resolved
edx_rest_framework_extensions/auth/jwt/tests/test_authentication.py
Outdated
Show resolved
Hide resolved
syedsajjadkazmii
force-pushed
the
sajjad/VAN-1694
branch
4 times, most recently
from
19fc77c
to
c15bd24
Compare
robrap
reviewed
Jan 25, 2024
There was a problem hiding this comment.
Thanks for all the work.
- My change was merged, so you can rebase against master.
- I just looked at my final review comments and marked resolved. I did not re-review all the tests, etc.
- I give this a 👍, except it is difficult to review until you rebase. Feel free to have someone on your team do the final review after rebase (mostly to make sure the rebase looks good), or I can do that if you need me to.
- Remember to add CHANGELOG and version update for 10.1.0.
syedsajjadkazmii
force-pushed
the
sajjad/VAN-1694
branch
4 times, most recently
from
fe968a4
to
5709f13
Compare
Thank you for merging your changes. I have rebased the branch against the master and added CHANGELOG and version updates. If possible, could you please review now? |
robrap
approved these changes
Jan 26, 2024
This is the final step (in this library) of the rollout of forgiving JWTs as a replacement for the USE-JWT-COOKIE header. **BREAKING CHANGE:** Removed ENABLE_FORGIVING_JWT_COOKIES toggle. It is now permanently enabled. - The header USE-JWT-COOKIE was removed because it has been fully replaced by forgiving JWTs. - Removed temporary rollout custom attributes: use_jwt_cookie_requested, jwt_auth_request_user_not_found, and skip_jwt_vs_session_check. See ADR 0002-remove-use-jwt-cookie-header.rst for details.
syedsajjadkazmii
force-pushed
the
sajjad/VAN-1694
branch
from
5709f13
to
ae2968d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Unauthenticate in case of mismatch between JWT email and lms user email
JIRA:
VAN-1694