Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove libsass from base requirements for edx-ora2 #1986

Closed
Tracked by #21
, #31505
...
kdmccormick opened this issue Feb 15, 2023 · 1 comment · Fixed by #1987
Closed
Tracked by #21
, #31505
...

Remove libsass from base requirements for edx-ora2 #1986

kdmccormick opened this issue Feb 15, 2023 · 1 comment · Fixed by #1987
Assignees
@kdmccormick

Comments

@kdmccormick
Copy link
Member

kdmccormick commented Feb 15, 2023 •
edited
Loading

In order to speed up the edx-platform build time, we want to remove libsass from its base requirements. Of all packages that edx-platform installs, libsass literally takes the longest, probably because (a) it's implemented in C and (b) we pin a crazy old version of it which has no precompiled binaries available. Libsass is required for a specific part of the edx-platform build, but it's not required in production.

Even if we take libsass out of edx-platform base requirements, though, edx-ora2 lists libsass as a base requirement, so edx-platform would still install it transitively.

Thus, we need to either take libsass out of edx-ora2's base reqs, or we need to remove it from edx-ora2 entirely if it's not being used any more.
@kdmccormick kdmccormick mentioned this issue Feb 15, 2023
Open
4 tasks
This was referenced Mar 15, 2023
Closed
Open
@kdmccormick kdmccormick changed the title edx-ora2: Make libsass a development-only requirement Remove libsass from base requirements for edx-ora2 Jul 11, 2023
@kdmccormick kdmccormick transferred this issue from openedx/edx-platform Jul 11, 2023
kdmccormick added a commit to kdmccormick/edx-ora2 that referenced this issue Jul 11, 2023
@kdmccormick
build: remove unused libsass dependency
f5b6df0 
TODO will paste in details from PR description

Closes: openedx#1986
@kdmccormick kdmccormick mentioned this issue Jul 11, 2023
Merged
kdmccormick added a commit to kdmccormick/edx-ora2 that referenced this issue Jul 11, 2023
@kdmccormick
build: remove unused libsass dependency
ccb0ce8 
TODO will paste in details from PR description

Closes: openedx#1986
@kdmccormick
Copy link
Member Author

Should be fixed by #1987

@kdmccormick kdmccormick self-assigned this Jul 11, 2023
kdmccormick added a commit to kdmccormick/edx-ora2 that referenced this issue Jul 11, 2023
@kdmccormick
build: remove unused libsass dependency
fae49ca 
Bump version: 5.1.0 -> 5.2.0

TODO will paste in details from PR description

Closes: openedx#1986
kdmccormick added a commit to kdmccormick/edx-ora2 that referenced this issue Jul 18, 2023
@kdmccormick
build: remove unused libsass dependency
8798579 
Bump version: 5.1.1 -> 5.2.0

TODO will paste in details from PR description

Closes: openedx#1986
kdmccormick added a commit that referenced this issue Jul 18, 2023
@kdmccormick
build: remove unused libsass dependency (#1987)
f9355d1 
(Bumps version: 5.1.1 -> 5.2.0)

We remove the libsass Python requirement as it doesn't seem to be used
any more. (I was able to compile ORA's assets by running `make static`;
no Python dependencies needed.) Removing libsass from ORA's requirements
will allow us to move it out of edx-platform's base requirements and into a new
static-asset-compilation-specific requirements stage.

Libsass [1] is a deprecated Sass compilation library written in C,
and installing it into edx-platform adds a whole minute to the
build because there are no pre-compiled binaries available
for the version we install.

1. https://sass-lang.com/libsass/

Closes: #1986
BryanttV pushed a commit to eduNEXT/edx-ora2 that referenced this issue Feb 6, 2024
@kdmccormick @BryanttV
build: remove unused libsass dependency (openedx#1987)
05ada11 
(Bumps version: 5.1.1 -> 5.2.0)

We remove the libsass Python requirement as it doesn't seem to be used
any more. (I was able to compile ORA's assets by running `make static`;
no Python dependencies needed.) Removing libsass from ORA's requirements
will allow us to move it out of edx-platform's base requirements and into a new
static-asset-compilation-specific requirements stage.

Libsass [1] is a deprecated Sass compilation library written in C,
and installing it into edx-platform adds a whole minute to the
build because there are no pre-compiled binaries available
for the version we install.

1. https://sass-lang.com/libsass/

Closes: openedx#1986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kdmccormick kdmccormick

Labels
None yet
Projects
No open projects
Developer Experience Working Group
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: remove unused libsass dependency kdmccormick/edx-ora2
1 participant
@kdmccormick