Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase item_id max lenght from 128 to 255 for peer, staff and studenttraining workflow #2183

Closed

Conversation

vunguyen-dmt
Copy link
Contributor

@vunguyen-dmt vunguyen-dmt commented Mar 1, 2024

TL;DR - [ A short summary of what this PR does and why ]
The current max length for item_id fields of peerworkflow, staffworkflow and studenttrainingworkflow is 128 characters which are insufficient for course_id with a length greater than 70 characters. This PR alters the max length of item_id from 128 to 255.

What changed?

  • Increase item_id max length of peerworkflow, staffworkflow and studenttrainingworkflow from 128 to 255.

Developer Checklist

Testing Instructions

  • Check if the definitions of these fields are varchar(255). openedx.assessment_peerworkflow.item_id, openedx.assessment_staffworkflow.item_id and openedx.assessment_studenttrainingworkflow.item_id.
  • Create a new course with an ID > 70 characters.
  • Create an Open Response component that has Student training and Peer and Staff steps.
  • Submit responses and assess them.

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@vunguyen-dmt vunguyen-dmt requested a review from a team as a code owner March 1, 2024 11:29
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 1, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @vunguyen-dmt! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@vunguyen-dmt
Copy link
Contributor Author

Hi @pomegranited, I made a PR following up on this post, please take a look.

@pomegranited
Copy link
Contributor

Thank you for submitting this @vunguyen-dmt ! Could you fix the commit lint error? (you'll need to use git push --force to push a new commit):

Error: You have commit messages with errors
⧗ input: fix: increase item_id max lenght from 128 to 255 for peerworkflow, staffworkflow and studenttrainingworkflow
✖ header must not be longer than 100 characters, current length is 108 [header-max-length]
✖ found 1 problems, 0 warnings
ⓘ Get help: https://open-edx-proposals.readthedocs.io/en/latest/oep-0051-bp-conventional-commits.html

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.01%. Comparing base (c76a89c) to head (ab4b080).
Report is 4 commits behind head on master.

❗ Current head ab4b080 differs from pull request most recent head 56b13d4. Consider uploading reports for the commit 56b13d4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2183      +/-   ##
==========================================
+ Coverage   94.99%   95.01%   +0.01%     
==========================================
  Files         191      191              
  Lines       20999    21014      +15     
  Branches     1898     1899       +1     
==========================================
+ Hits        19949    19966      +17     
+ Misses        786      785       -1     
+ Partials      264      263       -1     
Flag Coverage Δ
unittests 95.01% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vunguyen-dmt vunguyen-dmt changed the title fix: increase item_id max lenght from 128 to 255 for peerworkflow, staffworkflow and studenttrainingworkflow fix: increase item_id max lenght from 128 to 255 for peer, staff and studenttraining workflow Mar 5, 2024
@pomegranited
Copy link
Contributor

Hi @vunguyen-dmt , the error happened because your commit message's 1st line is too long. To fix it, you can do this:

# From your branch, run:
git commit --amend

# ^ command opens your editor.
# 1. Wrap the first line around to another line.
# 2. Save

# This pushes your updated commit message to this PR.
git push --force

@openedx-webhooks
Copy link

@vunguyen-dmt Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@vunguyen-dmt vunguyen-dmt deleted the increase_item_id_max_length branch March 6, 2024 09:55
@itsjeyd itsjeyd added the duplicate This issue or pull request already exists elsewhere label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists elsewhere open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants