New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: increase item_id max lenght from 128 to 255 for peer, staff and studenttraining workflow #2183
fix: increase item_id max lenght from 128 to 255 for peer, staff and studenttraining workflow #2183
Conversation
Thanks for the pull request, @vunguyen-dmt! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi @pomegranited, I made a PR following up on this post, please take a look. |
Thank you for submitting this @vunguyen-dmt ! Could you fix the commit lint error? (you'll need to use
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2183 +/- ##
==========================================
+ Coverage 94.99% 95.01% +0.01%
==========================================
Files 191 191
Lines 20999 21014 +15
Branches 1898 1899 +1
==========================================
+ Hits 19949 19966 +17
+ Misses 786 785 -1
+ Partials 264 263 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hi @vunguyen-dmt , the error happened because your commit message's 1st line is too long. To fix it, you can do this:
|
…studenttraining workflow
ab4b080
to
56b13d4
Compare
@vunguyen-dmt Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
TL;DR - [ A short summary of what this PR does and why ]
The current max length for item_id fields of peerworkflow, staffworkflow and studenttrainingworkflow is 128 characters which are insufficient for course_id with a length greater than 70 characters. This PR alters the max length of item_id from 128 to 255.
What changed?
Developer Checklist
Testing Instructions
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora