Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase item_id max lenght from 128 to 255 for peer, staff and studenttraining workflows #2188

Merged

Conversation

vunguyen-dmt
Copy link
Contributor

@vunguyen-dmt vunguyen-dmt commented Mar 6, 2024

TL;DR - [ A short summary of what this PR does and why ]

The current max length for item_id fields of peerworkflow, staffworkflow and studenttrainingworkflow is 128 characters which are insufficient for course_id with a length greater than 70 characters. This PR alters the max length of item_id from 128 to 255.
Related forum post

What changed?

  • Increase item_id max length of peerworkflow, staffworkflow and studenttrainingworkflow from 128 to 255.

Developer Checklist

Testing Instructions

  1. Check if the definitions of these fields are varchar(255). openedx.assessment_peerworkflow.item_id, openedx.assessment_staffworkflow.item_id and openedx.assessment_studenttrainingworkflow.item_id.
  2. Create a new course with an ID > 70 characters.
  3. Create an Open Response component that has Student training and Peer and Staff steps.
  4. Submit responses and assess them.

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@vunguyen-dmt vunguyen-dmt requested a review from a team as a code owner March 6, 2024 10:25
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 6, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @vunguyen-dmt! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@vunguyen-dmt vunguyen-dmt changed the title fix: increase item_id max lenght from 128 to 255 for peer, staff and … fix: increase item_id max lenght from 128 to 255 for peer, staff and studenttraining workflows Mar 6, 2024
@vunguyen-dmt
Copy link
Contributor Author

Hi @pomegranited I messed up my commit a bit. I closed #2183 and create this new PR.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.03%. Comparing base (8de0eaf) to head (bed4e38).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2188   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files         191      191           
  Lines       21003    21003           
  Branches     1896     1896           
=======================================
  Hits        19960    19960           
  Misses        779      779           
  Partials      264      264           
Flag Coverage Δ
unittests 95.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change works as expected, thank you @vunguyen-dmt !

So that I can create a new release, could you please update the version string from 6.4.0 to 6.5.0 in these files:

👍

  • I tested this on my devstack by running migrations, then using previously-created ORA2 blocks, and creating new ones. Everything works as expected.
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation N/A
  • User-facing strings are extracted for translation N/A

@vunguyen-dmt
Copy link
Contributor Author

@pomegranited I've updated it.

@pomegranited
Copy link
Contributor

pomegranited commented Mar 7, 2024

@vunguyen-dmt Oh no, the dreaded commit lint error again ☹️ See OEP-51 Conventional commits for info.

Also, there's a quality issue with e6af99c -- there needs to be a newline at the end of that file.

So you'll need to repair those commits and force push to replace them in this PR. Sorry about that!

Let me know if you have any trouble with this?

@vunguyen-dmt vunguyen-dmt force-pushed the fix_increase_item_id_max_length_02 branch 2 times, most recently from 81e6c85 to a8a6e8e Compare March 8, 2024 02:26
@vunguyen-dmt
Copy link
Contributor Author

@pomegranited I've made some changes, please help to check if there are still any issues.

@pomegranited pomegranited merged commit a7d4c66 into openedx:master Mar 8, 2024
9 checks passed
@openedx-webhooks
Copy link

@vunguyen-dmt 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@pomegranited
Copy link
Contributor

Thank you for your contribution, and for working through the CI issues @vunguyen-dmt !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants