New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: increase item_id max lenght from 128 to 255 for peer, staff and studenttraining workflows #2188
fix: increase item_id max lenght from 128 to 255 for peer, staff and studenttraining workflows #2188
Conversation
…studenttraining workflows
Thanks for the pull request, @vunguyen-dmt! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Hi @pomegranited I messed up my commit a bit. I closed #2183 and create this new PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2188 +/- ##
=======================================
Coverage 95.03% 95.03%
=======================================
Files 191 191
Lines 21003 21003
Branches 1896 1896
=======================================
Hits 19960 19960
Misses 779 779
Partials 264 264
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change works as expected, thank you @vunguyen-dmt !
So that I can create a new release, could you please update the version string from 6.4.0
to 6.5.0
in these files:
👍
- I tested this on my devstack by running migrations, then using previously-created ORA2 blocks, and creating new ones. Everything works as expected.
- I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationN/A -
User-facing strings are extracted for translationN/A
@pomegranited I've updated it. |
@vunguyen-dmt Oh no, the dreaded commit lint error again Also, there's a quality issue with e6af99c -- there needs to be a newline at the end of that file. So you'll need to repair those commits and force push to replace them in this PR. Sorry about that! Let me know if you have any trouble with this? |
81e6c85
to
a8a6e8e
Compare
@pomegranited I've made some changes, please help to check if there are still any issues. |
@vunguyen-dmt 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Thank you for your contribution, and for working through the CI issues @vunguyen-dmt ! |
TL;DR - [ A short summary of what this PR does and why ]
The current max length for item_id fields of peerworkflow, staffworkflow and studenttrainingworkflow is 128 characters which are insufficient for course_id with a length greater than 70 characters. This PR alters the max length of item_id from 128 to 255.
Related forum post
What changed?
Developer Checklist
Testing Instructions
Reviewer Checklist
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora