Ensure setup.cfg is only ASCII. CRI-169 #23872
Conversation
I don't understand why this file needs to be ASCII, or why it was only a problem recently for one installer, since this has been in this file since 2014. But CRI-169 has a stack trace, and it's easy enough to make the file ASCII.
|
Your PR has finished running tests. There were no failures. |
|
This may have been fixed by pypa/setuptools#1180 in setuptools 40.7.0, we're still pinning to 39.0.1 in the configuration repo. This PR is the fastest way to fix the issue, but do you think we should also upgrade setuptools and pip before the Juniper release? We were getting ready to do that very soon anyway. |
|
@jmbowman yes, if you want to do it soon, I think it would be good to do it in the next few days for Juniper. Thanks. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR may have caused e2e tests to fail on Stage. If you're a member of the edX org, please visit #e2e-troubleshooting on Slack to help diagnose the cause of these failures. Otherwise, it is the reviewer's responsibility. E2E tests have failed. https://gocd.tools.edx.org/go/tab/pipeline/history/deploy_to_stage |
|
EdX Release Notice: This PR has been deployed to the production environment. |
I don't understand why this file needs to be ASCII, or why it was only a
problem recently for one installer, since this has been in this file
since 2014. But CRI-169 has a stack trace, and it's easy enough to make
the file ASCII.