Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add open_managed team type #33672

Merged
merged 5 commits into from
Feb 14, 2024
Merged

feat: add open_managed team type #33672

merged 5 commits into from
Feb 14, 2024

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Nov 7, 2023

Description

Create a new open_managed team type. Ref: https://openedx.atlassian.net/wiki/spaces/COMM/pages/3885760525/Open+Managed+Group+Type

Testing instructions

  1. Clone frontend-app-course-authoring from the following PR feat: add open managed group type frontend-app-course-authoring#669
  2. Mount the repo as editable in tutor: tutor mounts add frontend-app-course-authoring
  3. Go to the CMS -> Pages and Resources -> Teams, and enable teams:
    image
  4. Create a new group of type Open managed
    image
  5. Verify users can join and see other teams but cannot create new teams.
    image

Deadline

None

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 7, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 7, 2023 •
edited

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@Ian2012 Ian2012 mentioned this pull request Nov 7, 2023
Merged
@Ian2012 Ian2012 marked this pull request as ready for review November 9, 2023 21:09
@Ian2012 Ian2012 marked this pull request as draft November 9, 2023 21:12
felipemontoya
felipemontoya reviewed Nov 10, 2023
View reviewed changes
Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good to me. @Ian2012 do you think we could graduate it from draft already?

@Ian2012
Copy link
Contributor Author

Ian2012 commented Nov 10, 2023

@felipemontoya I think so, do we need to add tests for it?

@Ian2012 Ian2012 marked this pull request as ready for review November 10, 2023 18:52
@Ian2012 Ian2012 changed the title [POC] feat: add open_managed team type feat: add open_managed team type Nov 14, 2023
@Ian2012 Ian2012 force-pushed the cag/open-managed-team branch 4 times, most recently from 0d5985d to ae1b2ab Compare November 22, 2023 16:17
@Ian2012
Copy link
Contributor Author

Ian2012 commented Nov 22, 2023

@felipemontoya @mariajgrimaldi this is ready for review

mariajgrimaldi
mariajgrimaldi reviewed Dec 1, 2023
View reviewed changes
Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test this in my local environment and let you know how it goes! Thanks

@mariajgrimaldi mariajgrimaldi self-assigned this Dec 1, 2023
mariajgrimaldi
mariajgrimaldi approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patience! I tested out this locally in my environment, and it's working as expected:

Screencast.from.18-01-24.13.47.02.mp4

Sidenote: The error you see is because I don't have forum enabled, so an exception is raised.

@mariajgrimaldi
Copy link
Member

@mphilbrick211: I did the engineering review on this PR, so this is ready to merge. But first, can we call in a member of the teams' app maintainer team? They'll need to know this is coming their way. Thanks!

@mariajgrimaldi mariajgrimaldi merged commit 5a36fa9 into openedx:master Feb 14, 2024
63 checks passed
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariajgrimaldi mariajgrimaldi mariajgrimaldi approved these changes

@felipemontoya felipemontoya Awaiting requested review from felipemontoya

@johnvente johnvente Awaiting requested review from johnvente

Assignees

@mariajgrimaldi mariajgrimaldi

Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Ian2012 @openedx-webhooks @mariajgrimaldi @edx-pipeline-bot @felipemontoya @johnvente