feat: add open managed group type #669

Ian2012 · 2023-11-07T17:26:47Z

Settings

EDX_PLATFORM_REPOSITORY: https://github.com/openedx/edx-platform.git
EDX_PLATFORM_VERSION: master

TUTOR_GROVE_LMS_ENV_FEATURES: |
  ENABLE_TEAMS: True

TUTOR_GROVE_MFE_LMS_COMMON_SETTINGS: |
  MFE_CONFIG["ENABLE_OPEN_MANAGED_TEAM_TYPE"] = True

Description

This PR adds support for the new open managed group type. Ref: https://openedx.atlassian.net/wiki/spaces/COMM/pages/3885760525/Open+Managed+Group+Type

Screenshots

Dependencies:

Depends on: openedx/edx-platform#33672

openedx-webhooks · 2023-11-07T17:26:52Z

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov · 2023-11-07T17:44:57Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (3c661e1) to head (80454ee).
Report is 20 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #669      +/-   ##
==========================================
+ Coverage   90.94%   91.30%   +0.36%     
==========================================
  Files         520      561      +41     
  Lines        9157     9767     +610     
  Branches     1920     2081     +161     
==========================================
+ Hits         8328     8918     +590     
- Misses        797      816      +19     
- Partials       32       33       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mphilbrick211 · 2023-11-07T22:39:46Z

Hi @openedx/teaching-and-learning! This is ready for your review. Thanks!

openedx-webhooks · 2023-11-08T02:31:55Z

I've created issue TNL-11193 in the private 2U Jira.

felipemontoya

Can we reorder the list so that "Open Managed" is between "Open" and "Public Managed"?
I think it makes sense since it creates a progression from fully open to fully private.

src/pages-and-resources/teams/messages.js

sundasnoreen12

PR LGTM

felipemontoya

Reviewed again. I think this is good.
This should be merged after edx-platform/pull/33672, right?

Ian2012 · 2023-11-16T19:46:31Z

Yes, it should. Waiting on review there

felipemontoya · 2024-02-13T23:30:03Z

@Ian2012 sorry to come up so late with this request but to be extra safe when merging this. Could you please leave this feature behind a feature flag?

CC @mariajgrimaldi in case you are taking over this feature.

mariajgrimaldi · 2024-02-14T13:42:55Z

Hi there @felipemontoya, that's precisely what I did in this PR: #801, but I'll cherry-pick the changes here since they're needed. Thank you.

mariajgrimaldi · 2024-02-14T14:42:53Z

@felipemontoya: done! Could you review this again? Thanks!

mariajgrimaldi · 2024-02-14T14:46:12Z

I can't update the cover letter, so I leave here the updated testing instructions:

Follow the instructions in the PR feat: add open managed group type #669.
Check the team options. The Open Managed team should be off as default.
Now, turn on the new team option by adding this to your LMS configuration:

    MFE_CONFIG_OVERRIDES = {
      "course-authoring": {
          "ENABLE_OPEN_MANAGED_TEAM_TYPE": True,
      }
    }

felipemontoya

Thanks a lot for moving this behind a flag @mariajgrimaldi.

I re-tested this today. The code is working on a tutor based environment together with the changes of the platform that were merged on PR 33672.

I think this is ready to be merged.

it has product approval
it has a core committer approval and 2 approvals by the 2u team.
tests are running and passing
the feature includes it's own tests
the feature is behind a flag that is switched off by default. This won't impact edx.org's operation in any way.

felipemontoya · 2024-02-27T00:29:42Z

@arbrandes or @brian-smith-tcril could one of you help us get the green button pushed? There is no backstage catalog file so I don't know who to flag as the maintainer.

arbrandes · 2024-02-27T14:38:05Z

@felipemontoya, I'll be glad to, but my first question is: has this received product approval, yet?

Tagging @jmakowski1123 preemptively.

open-craft-grove · 2024-02-27T15:37:07Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

felipemontoya · 2024-02-27T17:30:25Z

Great! sandboxes are working.

I don't know how to access that sandbox as an instructor user, and also I don't know how to make sure that the settings are complete, but overall I love sandboxes.

open-craft-grove · 2024-02-27T18:15:23Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

arbrandes · 2024-02-27T18:19:50Z

@felipemontoya, custom settings are at the top of the PR description. There's docs at https://gitlab.com/opencraft/dev/grove/-/blob/main/docs/user-guides/automated-pr-sandbox.md and at https://gitlab.com/opencraft/dev/tutor-contrib-grove.

I'll send you access details off-band.

mariajgrimaldi · 2024-03-01T21:07:50Z

Fixed branch conflicts just now.

open-craft-grove · 2024-03-01T21:40:42Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

mariajgrimaldi · 2024-03-02T00:07:45Z

I'll be fixing the failing tests soon; thanks for the patience.

open-craft-grove · 2024-03-03T23:43:24Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-03-04T19:05:00Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

mariajgrimaldi · 2024-03-07T21:48:16Z

Hello @arbrandes! This is ready for review if you have the time. Thanks!

arbrandes · 2024-03-08T13:49:47Z

@mariajgrimaldi, in the sandbox, I can't configure Teams as instructed in the the backend PR. Any idea why that might be? A missing configuration item, perhaps?

mariajgrimaldi · 2024-03-08T16:17:28Z

@arbrandes: I'll look into it!

mariajgrimaldi · 2024-03-08T16:57:06Z

@arbrandes: could you share the access details for the sandox? Thanks!

arbrandes

Works great! Just one nit.

arbrandes · 2024-03-08T18:22:28Z

plugins/course-apps/teams/utils.test.js

+
+    test('returns false if the group is invalid', () => {
+      getConfig.mockReturnValue({ ENABLE_OPEN_MANAGED_TEAM_TYPE: true });
+      expect(isGroupTypeEnabled('')).toBe(false);


I'd feel safer if you made this an actual bogus value. Like:

Suggested change

expect(isGroupTypeEnabled('')).toBe(false);

expect(isGroupTypeEnabled('FOO')).toBe(false);

mariajgrimaldi · 2024-03-08T19:29:12Z

@arbrandes: done! Thank you

open-craft-grove · 2024-03-08T20:04:41Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

openedx-webhooks · 2024-03-12T19:42:14Z

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 7, 2023

Ian2012 marked this pull request as draft November 7, 2023 17:27

Ian2012 mentioned this pull request Nov 7, 2023

feat: add open_managed team type openedx/edx-platform#33672

Merged

Ian2012 marked this pull request as ready for review November 7, 2023 17:48

Ian2012 changed the title ~~POC] feat: add open managed group type~~ [POC] feat: add open managed group type Nov 7, 2023

mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Nov 7, 2023

mphilbrick211 requested a review from a team November 7, 2023 22:39

jristau1984 added the jira:2u We want an issue in the 2U Jira instance label Nov 8, 2023

felipemontoya suggested changes Nov 10, 2023

View reviewed changes

src/pages-and-resources/teams/messages.js Outdated Show resolved Hide resolved

Ian2012 force-pushed the cag/open-managed-team branch from d4b586d to fae018c Compare November 14, 2023 15:08

awais-ansari approved these changes Nov 15, 2023

View reviewed changes

src/pages-and-resources/teams/messages.js Outdated Show resolved Hide resolved

sundasnoreen12 approved these changes Nov 16, 2023

View reviewed changes

felipemontoya approved these changes Nov 16, 2023

View reviewed changes

Ian2012 changed the title ~~[POC] feat: add open managed group type~~ feat: add open managed group type Nov 16, 2023

mariajgrimaldi mentioned this pull request Jan 18, 2024

refactor!: put open manage team behind a configuration flag #801

Closed

mariajgrimaldi force-pushed the cag/open-managed-team branch from 68ed4e5 to 51687ad Compare January 30, 2024 18:20

mariajgrimaldi force-pushed the cag/open-managed-team branch from 51687ad to 2213926 Compare February 13, 2024 18:09

mphilbrick211 removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 21, 2024

felipemontoya approved these changes Feb 27, 2024

View reviewed changes

arbrandes self-requested a review February 27, 2024 15:12

Ian2012 and others added 5 commits March 1, 2024 17:06

feat: add open managed group type

c62f84a

fix: reorder groups

daf2ea0

chore: update open managed description

cec8bc0

chore: fix typo

61d08a5

refactor!: put open manage team behind a configuration flag

86115c2

mariajgrimaldi force-pushed the cag/open-managed-team branch from 4215a51 to 86115c2 Compare March 1, 2024 21:07

mariajgrimaldi added 2 commits March 3, 2024 19:04

fix: import grouptypes from correct file

88ff083

fix: import grouptypes from correct file

47609ff

arbrandes requested changes Mar 8, 2024

View reviewed changes

refactor: address PR reviews

80454ee

mariajgrimaldi requested a review from arbrandes March 11, 2024 14:54

arbrandes approved these changes Mar 12, 2024

View reviewed changes

arbrandes merged commit 7f5687f into openedx:master Mar 12, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add open managed group type #669

feat: add open managed group type #669

Ian2012 commented Nov 7, 2023 •

edited by arbrandes

openedx-webhooks commented Nov 7, 2023 •

edited

codecov bot commented Nov 7, 2023 •

edited

mphilbrick211 commented Nov 7, 2023

openedx-webhooks commented Nov 8, 2023

felipemontoya left a comment

sundasnoreen12 left a comment

felipemontoya left a comment

Ian2012 commented Nov 16, 2023

felipemontoya commented Feb 13, 2024

mariajgrimaldi commented Feb 14, 2024 •

edited

mariajgrimaldi commented Feb 14, 2024

mariajgrimaldi commented Feb 14, 2024

felipemontoya left a comment •

edited

felipemontoya commented Feb 27, 2024

arbrandes commented Feb 27, 2024

open-craft-grove commented Feb 27, 2024

felipemontoya commented Feb 27, 2024

open-craft-grove commented Feb 27, 2024

arbrandes commented Feb 27, 2024

mariajgrimaldi commented Mar 1, 2024

open-craft-grove commented Mar 1, 2024

mariajgrimaldi commented Mar 2, 2024

open-craft-grove commented Mar 3, 2024

open-craft-grove commented Mar 4, 2024

mariajgrimaldi commented Mar 7, 2024

arbrandes commented Mar 8, 2024

mariajgrimaldi commented Mar 8, 2024

mariajgrimaldi commented Mar 8, 2024

arbrandes left a comment

arbrandes Mar 8, 2024

mariajgrimaldi commented Mar 8, 2024

open-craft-grove commented Mar 8, 2024

openedx-webhooks commented Mar 12, 2024

	expect(isGroupTypeEnabled('')).toBe(false);
	expect(isGroupTypeEnabled('FOO')).toBe(false);

feat: add open managed group type #669

feat: add open managed group type #669

Conversation

Ian2012 commented Nov 7, 2023 • edited by arbrandes

Description

Screenshots

Dependencies:

openedx-webhooks commented Nov 7, 2023 • edited

codecov bot commented Nov 7, 2023 • edited

Codecov Report

mphilbrick211 commented Nov 7, 2023

openedx-webhooks commented Nov 8, 2023

felipemontoya left a comment

Choose a reason for hiding this comment

sundasnoreen12 left a comment

Choose a reason for hiding this comment

felipemontoya left a comment

Choose a reason for hiding this comment

Ian2012 commented Nov 16, 2023

felipemontoya commented Feb 13, 2024

mariajgrimaldi commented Feb 14, 2024 • edited

mariajgrimaldi commented Feb 14, 2024

mariajgrimaldi commented Feb 14, 2024

felipemontoya left a comment • edited

Choose a reason for hiding this comment

felipemontoya commented Feb 27, 2024

arbrandes commented Feb 27, 2024

open-craft-grove commented Feb 27, 2024

felipemontoya commented Feb 27, 2024

open-craft-grove commented Feb 27, 2024

arbrandes commented Feb 27, 2024

mariajgrimaldi commented Mar 1, 2024

open-craft-grove commented Mar 1, 2024

mariajgrimaldi commented Mar 2, 2024

open-craft-grove commented Mar 3, 2024

open-craft-grove commented Mar 4, 2024

mariajgrimaldi commented Mar 7, 2024

arbrandes commented Mar 8, 2024

mariajgrimaldi commented Mar 8, 2024

mariajgrimaldi commented Mar 8, 2024

arbrandes left a comment

Choose a reason for hiding this comment

arbrandes Mar 8, 2024

Choose a reason for hiding this comment

mariajgrimaldi commented Mar 8, 2024

open-craft-grove commented Mar 8, 2024

openedx-webhooks commented Mar 12, 2024

Ian2012 commented Nov 7, 2023 •

edited by arbrandes

openedx-webhooks commented Nov 7, 2023 •

edited

codecov bot commented Nov 7, 2023 •

edited

mariajgrimaldi commented Feb 14, 2024 •

edited

felipemontoya left a comment •

edited