Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed dynamic learner profile issue #493

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Conversation

sundasnoreen12
Copy link
Contributor

@sundasnoreen12 sundasnoreen12 commented Apr 4, 2023

INF-385

Description

Fixed dynamic image issue by displaying dummy avatar to make it consistent throughout the discussion MFE.

How Has This Been Tested?
Please describe in detail how you tested your changes.

Before

Screenshot 2023-04-05 at 12 40 40 PM

After

Screenshot 2023-04-05 at 12 40 40 PM

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (5cc5156) 92.17% compared to head (7cedfe1) 92.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
- Coverage   92.17%   92.15%   -0.02%     
==========================================
  Files         163      163              
  Lines        3259     3251       -8     
  Branches      889      889              
==========================================
- Hits         3004     2996       -8     
  Misses        236      236              
  Partials       19       19              
Impacted Files Coverage Δ
src/discussions/learners/data/selectors.js 100.00% <ø> (ø)
src/discussions/learners/learner/LearnerAvatar.jsx 100.00% <ø> (ø)
...s/post-comments/comments/comment/CommentHeader.jsx 100.00% <ø> (ø)
...scussions/post-comments/comments/comment/Reply.jsx 58.82% <ø> (-1.18%) ⬇️
src/discussions/posts/data/selectors.js 93.75% <ø> (-0.70%) ⬇️
src/discussions/posts/post/PostHeader.jsx 89.47% <ø> (-0.27%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sundasnoreen12 sundasnoreen12 changed the title Sundas/inf 385 fix: fixed dynamic learner profile issue Apr 4, 2023
Copy link
Contributor

@awais-ansari awais-ansari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test coverage is reduced. Please take a look other than LGTM.

@sundasnoreen12 sundasnoreen12 merged commit c1478db into master Apr 5, 2023
@sundasnoreen12 sundasnoreen12 deleted the sundas/INF-385 branch April 5, 2023 11:21
moonesque pushed a commit to edSPIRIT/frontend-app-discussions that referenced this pull request Nov 11, 2023
* fix: fixed dynamic URL issue

* refactor: removed unused selectors

---------

Co-authored-by: sundasnoreen12 <sundasnoreen12@ggmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants