-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: posts sorting on sidebar #686
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @dyudyunov! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
My changes require further improvements - there are unneeded additional GET requests to the threads endpoint. I will change the status to Draft for now |
7f3e838
to
97a69da
Compare
I figured out how to get rid of the unneeded API call, now it's ready for the review |
Tests CI seems to be canceled because of the timeout Does anyone know the reason? |
@dyudyunov Not sure about it. |
97a69da
to
ae6e989
Compare
Rebased on fresh master branch Hope it will fix the pipeline timeout issue |
Hi @dyudyunov! Do you still need help with this? If so, I can look into it for you. |
Fix wrong sorting when a user creates several posts without the page reloading.
ae6e989
to
43ef4f4
Compare
Sorry for the delayed response Yes, I need some help here, the timeout issue is still reproducing (I rebased the working branch today to re-check) and I don't know the reason. I also saw that other PRs have the same issue |
Checking on this for you, @dyudyunov! |
Description
Fix wrong sorting when a user creates several posts without the page reloading.
Steps to reproduce
Actual result
The second created post is the last in the list (the same for any number of posts created additionally).
Expected result (with the fix applied)
Sorting works as expected - most recent posts are displayed first.
Additional Notes
That's because when you create a post in the Discussions MFE itself - you will be navigated to the "My Posts" tab and the list of the posts will always be fetched.