Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACKPORT] fix: posts sorting on sidebar #687

Open
wants to merge 1 commit into
base: open-release/quince.master
Choose a base branch
from

Conversation

dyudyunov
Copy link
Contributor

Backport from the master

Description

Fix wrong sorting when a user creates several posts without the page reloading.

Steps to reproduce

  1. [Precondition] The new discussions experience (discussions sidebar) should be enabled
  2. Navigate to any course unit where the discussions sidebar is enabled
  3. Create a new post.
  4. Click on the "Back to list" button. Note that the default sorting is used (most recent first) and it's correct.
  5. Create another post without reloading the page
  6. Click on the "Back to list" button and check the result

Actual result

The second created post is the last in the list (the same for any number of posts created additionally).

image

Expected result (with the fix applied)

Sorting works as expected - most recent posts are displayed first.

discuss_sorting

Additional Notes

  • Reproduces only with the discussions sidebar inside the Learning MFE.
    That's because when you create a post in the Discussions MFE itself - you will be navigated to the "My Posts" tab and the list of the posts will always be fetched.
  • Sorting works as expected after the page is reloaded.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 29, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @dyudyunov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Mar 29, 2024
@dyudyunov
Copy link
Contributor Author

My changes require further improvements - there are unneeded additional GET requests to the threads endpoint.

I will change the status to Draft for now

@dyudyunov dyudyunov changed the title [BACKPORT] fix: posts sorting on sidebar [DRAFT][BACKPORT] fix: posts sorting on sidebar Apr 1, 2024
Fix wrong sorting when a user creates several posts
without the page reloading.
@dyudyunov dyudyunov force-pushed the quince/fix-posts-sorting-on-sidebar branch from 0856b8d to 22b0eb4 Compare April 1, 2024 07:58
@dyudyunov dyudyunov changed the title [DRAFT][BACKPORT] fix: posts sorting on sidebar [BACKPORT] fix: posts sorting on sidebar Apr 1, 2024
@dyudyunov
Copy link
Contributor Author

My changes require further improvements - there are unneeded additional GET requests to the threads endpoint.

I will change the status to Draft for now

I figured out how to get rid of the unneeded API call, now it's ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

None yet

3 participants