-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use atlas
in make pull_translations
#278
Conversation
Thanks for the pull request, @OmarIthawi! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #278 +/- ##
=======================================
Coverage 50.00% 50.00%
=======================================
Files 15 15
Lines 164 164
Branches 28 28
=======================================
Hits 82 82
Misses 77 77
Partials 5 5
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell the codecov issue can be ignored. LGTM!
Changes ------- - Bump frontend-platform to bring `intl-imports.js` script - Move all i18n imports into `src/i18n/index.js` so `intl-imports.js` can override it with latest translations - Add `atlas` into `make pull_translations` when `OPENEDX_ATLAS_PULL` environment variable is set. Refs: [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) implementing Translation Infrastructure OEP-58.
@colinbrash the spreadsheet has you listed as "Review required from:", any chance you could review/merge this one? |
@OmarIthawi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Changes ------- - Bump frontend-platform to bring `intl-imports.js` script - Move all i18n imports into `src/i18n/index.js` so `intl-imports.js` can override it with latest translations - Add `atlas` into `make pull_translations` when `OPENEDX_ATLAS_PULL` environment variable is set. Refs: [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) implementing Translation Infrastructure OEP-58.
Changes ------- - Bump frontend-platform to bring `intl-imports.js` script - Move all i18n imports into `src/i18n/index.js` so `intl-imports.js` can override it with latest translations - Add `atlas` into `make pull_translations` when `OPENEDX_ATLAS_PULL` environment variable is set. Refs: [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) implementing Translation Infrastructure OEP-58.
* Update standard workflow files. (#263) * build: Create a missing workflow file `self-assign-issue.yml`. The .github/workflows/self-assign-issue.yml workflow is missing or needs an update to stay in sync with the current standard for this workflow as defined in the `.github` repo of the `openedx` GitHub org. * build: Create a missing workflow file `add-remove-label-on-comment.yml`. The .github/workflows/add-remove-label-on-comment.yml workflow is missing or needs an update to stay in sync with the current standard for this workflow as defined in the `.github` repo of the `openedx` GitHub org. * build: Update a workflow file `add-depr-ticket-to-depr-board.yml`. The .github/workflows/add-depr-ticket-to-depr-board.yml workflow is missing or needs an update to stay in sync with the current standard for this workflow as defined in the `.github` repo of the `openedx` GitHub org. * chore(i18n): add more languages (#261) * chore(i18n): add more languages * chore(i18n): Pylint fixes * feat: use `atlas` in `make pull_translations` (#278) Changes ------- - Bump frontend-platform to bring `intl-imports.js` script - Move all i18n imports into `src/i18n/index.js` so `intl-imports.js` can override it with latest translations - Add `atlas` into `make pull_translations` when `OPENEDX_ATLAS_PULL` environment variable is set. Refs: [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) implementing Translation Infrastructure OEP-58. * feat: upgraded to node v18, added .nvmrc and updated workflows (#274) * feat: upgraded to node v18, added .nvmrc and updated workflows * build: update frontrnf-build * build: upgrade pkgs * build: update @edx/browserslist-config to the latest * refactor: update packages * feat: add subscriptions section to orders page (#289) * feat: design changes for subscriptions (#276) * feat: api integration for subscription related changes (#282) * feat: add manage subscriptions url and update subscription upsell (#288) * test: add more tests for subscriptions --------- Co-authored-by: Nawfal Ahmed <111358247+NawfalAhmed@users.noreply.github.com> Co-authored-by: Nawfal Ahmed <nawfal.ahmed@arbisoft.com> * fix: fix getting b2c subscriptions flag for stage (#290) * refactor: update components and utils folder structure * feat: improve subscription section and add basic alerts * fix: revert change to container (#292) * Automate Browserlist DB Update (#221) * feat: added cron github action to auto update brwoserlist DB periodically * refactor: used a shared script to update broswerslist DB, create PR and automerge it * Paragon table deprecation migration to DataTable (#200) * refactor: changed derecated table component to datatable * refactor: fixed warning of missing props * refactor: changed DataTable to DataTable.Table as suggested in code review * refactor: used DataTable.Table directly to remove count * fix: fixed pagination styling issue * fix: fixed snapshot test * PON-251: Update Existing Error Handling (#294) * feat: update order history error flows * refactor: remove unused AsyncActionType, favour saga routines over this * fix: add sr message to loading, fix order history loading * test: add more tests for coverage * feat: update error UX for manage subscriptions (#299) * chore(i18n): update translations (#301) Co-authored-by: Jenkins <sre+jenkins@edx.org> * feat: handle subscription api statuscode flag (#304) * feat: add translations for subscription state badges (#305) * fix: fix unmarked translations (#306) * chore(i18n): update translations * chore(i18n): update translations (#308) Co-authored-by: Jenkins <sre+jenkins@edx.org> * feat: add subscriptions marketing url (#309) * docs: update readme to reflect recent subscription changes (#312) * feat: move subscription upsell values behind env (#314) * feat: use react-testing-library for detailed unit tests (#316) * feat: use react-testing-library for tests * feat: update tests for Subscriptions * feat: update tests for NotFoundPage * feat: update tests for ManageSubscriptions * feat: update tests for OrdersandSubscriptions * chore: added CODEOWNERS file to enable branch protection policy (REV-3441) (#283) * chore: added CODEOWNERS file to enable branch protection policy * fix: updated @edx/revenue-squad team tag * fix: updated @openedx/revenue-squad team tag * chore: added self check for CODEOWNERS file and updated file path to /src * feat: disable subscriptions for local (#318) * Removed subscription section from Readme file (#322) * fix: removed subscription section and subs screenshot from readme file * feat: update react & react-dom to v17 (#302) * feat: update react & react-dom to v17 * build: update edx pkgs * build: update lock file --------- Co-authored-by: Feanil Patel <feanil@tcril.org> Co-authored-by: Yoiber <105317298+Yoiber071@users.noreply.github.com> Co-authored-by: Omar Al-Ithawi <i@omardo.com> Co-authored-by: Mashal Malik <107556986+Mashal-m@users.noreply.github.com> Co-authored-by: Shafqat Farhan <shafqat.farhan@arbisoft.com> Co-authored-by: Nawfal Ahmed <111358247+NawfalAhmed@users.noreply.github.com> Co-authored-by: Nawfal Ahmed <nawfal.ahmed@arbisoft.com> Co-authored-by: Muhammad Abdullah Waheed <42172960+abdullahwaheed@users.noreply.github.com> Co-authored-by: edx-transifex-bot <edx-transifex-bot@users.noreply.github.com> Co-authored-by: Jenkins <sre+jenkins@edx.org> Co-authored-by: Muhammad Mattiullah <50130127+MuhammadMattiullah@users.noreply.github.com> Co-authored-by: Shahroz Ahmad <97090106+ishahroz@users.noreply.github.com>
Changes
intl-imports.js
scriptsrc/i18n/index.js
sointl-imports.js
can override it with latest translationsatlas
intomake pull_translations
whenOPENEDX_ATLAS_PULL
environment variable is set.Refs: FC-0012 project implementing Translation Infrastructure OEP-58.
Testing
Screenshot
Yeah, not much strings. But just to test the UI after$ OPENEDX_ATLAS_PULL=yes make pull_translations
:Anyone merging to this repository is expected to release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.
References
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.
Join the conversation on Open edX Slack #translations-project-fc-0012.
Check the links above for full information about the overall project.
Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:
.json
,.po
or.mo
files will be committed into the repos.make extract_translations
in all repositoriesBreaking Changes
One of the primary goals of the project is to avoid breaking changes. If you noticed any suspicious code, please raise your concern. But before that, please know the strategy we're following to avoid breaking changes:
For Micro-frontends:
src/i18n/index.js
atlas
integration inmake pull_translations
but only ifOPENEDX_ATLAS_PULL
is setintl-imports.js
to generate up to date import files