Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added CODEOWNERS file to enable branch protection policy (REV-3441) #283

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

ishahroz
Copy link
Member

Anyone merging to this repository is expected to release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.

Description

Describe what this pull request changes, and why these changes were made. How will these changes affect other people, installations of edx, etc.?
Please include links to any relevant ADRs, design artifacts, and decision documents. Make sure to document the rationale behind significant changes in the repo, per OEP-19, and can be
linked here.

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner", "Course Author", "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these changes.

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for testing this change; how did YOU test this change?

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, OpenEdx vs. edx.org differences, development vs. production environment differences, security, or accessibility.

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: +11.91% 🎉

Comparison is base (938d3e1) 50.00% compared to head (4ac8082) 61.91%.
Report is 20 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #283       +/-   ##
===========================================
+ Coverage   50.00%   61.91%   +11.91%     
===========================================
  Files          15       34       +19     
  Lines         164      323      +159     
  Branches       28       68       +40     
===========================================
+ Hits           82      200      +118     
- Misses         77      117       +40     
- Partials        5        6        +1     

see 33 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishahroz ishahroz requested a review from a team May 12, 2023 09:22
@zubair-ce07 zubair-ce07 closed this Aug 3, 2023
@zubair-ce07 zubair-ce07 reopened this Aug 3, 2023
@zubair-ce07 zubair-ce07 merged commit 9778543 into master Aug 3, 2023
8 checks passed
@zubair-ce07 zubair-ce07 deleted the ishahroz/chore_CODEOWNERS_file branch August 3, 2023 13:33
grmartin added a commit that referenced this pull request Aug 29, 2023
* Update standard workflow files. (#263)

* build: Create a missing workflow file `self-assign-issue.yml`.

The .github/workflows/self-assign-issue.yml workflow is missing or needs an update to stay in
sync with the current standard for this workflow as defined in the
`.github` repo of the `openedx` GitHub org.

* build: Create a missing workflow file `add-remove-label-on-comment.yml`.

The .github/workflows/add-remove-label-on-comment.yml workflow is missing or needs an update to stay in
sync with the current standard for this workflow as defined in the
`.github` repo of the `openedx` GitHub org.

* build: Update a workflow file `add-depr-ticket-to-depr-board.yml`.

The .github/workflows/add-depr-ticket-to-depr-board.yml workflow is missing or needs an update to stay in
sync with the current standard for this workflow as defined in the
`.github` repo of the `openedx` GitHub org.

* chore(i18n): add more languages (#261)

* chore(i18n): add more languages

* chore(i18n): Pylint fixes

* feat: use `atlas` in `make pull_translations` (#278)

Changes
-------
 - Bump frontend-platform to bring `intl-imports.js` script
 - Move all i18n imports into `src/i18n/index.js` so `intl-imports.js` can
   override it with latest translations
 - Add `atlas` into `make pull_translations` when `OPENEDX_ATLAS_PULL`
   environment variable is set.

Refs: [FC-0012 project](https://openedx.atlassian.net/l/cp/XGS0iCcQ) implementing Translation Infrastructure OEP-58.

* feat: upgraded to node v18, added .nvmrc and updated workflows (#274)

* feat: upgraded to node v18, added .nvmrc and updated workflows

* build: update frontrnf-build

* build: upgrade pkgs

* build: update @edx/browserslist-config to the latest

* refactor: update packages

* feat: add subscriptions section to orders page (#289)

* feat: design changes for subscriptions (#276)

* feat: api integration for subscription related changes (#282)

* feat: add manage subscriptions url and update subscription upsell (#288)

* test: add more tests for subscriptions

---------

Co-authored-by: Nawfal Ahmed <111358247+NawfalAhmed@users.noreply.github.com>
Co-authored-by: Nawfal Ahmed <nawfal.ahmed@arbisoft.com>

* fix: fix getting b2c subscriptions flag for stage (#290)

* refactor: update components and utils folder structure

* feat: improve subscription section and add basic alerts

* fix: revert change to container (#292)

* Automate Browserlist DB Update (#221)

* feat: added cron github action to auto update brwoserlist DB periodically

* refactor: used a shared script to update broswerslist DB, create PR and automerge it

* Paragon table deprecation migration to DataTable (#200)

* refactor: changed derecated table component to datatable

* refactor: fixed warning of missing props

* refactor: changed DataTable to DataTable.Table as suggested in code review

* refactor: used DataTable.Table directly to remove count

* fix: fixed pagination styling issue

* fix: fixed snapshot test

* PON-251: Update Existing Error Handling (#294)

* feat: update order history error flows

* refactor: remove unused AsyncActionType, favour saga routines over this

* fix: add sr message to loading, fix order history loading

* test: add more tests for coverage

* feat: update error UX for manage subscriptions (#299)

* chore(i18n): update translations (#301)

Co-authored-by: Jenkins <sre+jenkins@edx.org>

* feat: handle subscription api statuscode flag (#304)

* feat: add translations for subscription state badges (#305)

* fix: fix unmarked translations (#306)

* chore(i18n): update translations

* chore(i18n): update translations (#308)

Co-authored-by: Jenkins <sre+jenkins@edx.org>

* feat: add subscriptions marketing url (#309)

* docs: update readme to reflect recent subscription changes (#312)

* feat: move subscription upsell values behind env (#314)

* feat: use react-testing-library for detailed unit tests (#316)

* feat: use react-testing-library for tests

* feat: update tests for Subscriptions

* feat: update tests for NotFoundPage

* feat: update tests for ManageSubscriptions

* feat: update tests for OrdersandSubscriptions

* chore: added CODEOWNERS file to enable branch protection policy (REV-3441) (#283)

* chore: added CODEOWNERS file to enable branch protection policy

* fix: updated @edx/revenue-squad team tag

* fix: updated @openedx/revenue-squad team tag

* chore: added self check for CODEOWNERS file and updated file path to /src

* feat: disable subscriptions for local (#318)

* Removed subscription section from Readme file (#322)

* fix: removed subscription section and subs screenshot from readme file

* feat: update react & react-dom to v17 (#302)

* feat: update react & react-dom to v17

* build: update edx pkgs

* build: update lock file

---------

Co-authored-by: Feanil Patel <feanil@tcril.org>
Co-authored-by: Yoiber <105317298+Yoiber071@users.noreply.github.com>
Co-authored-by: Omar Al-Ithawi <i@omardo.com>
Co-authored-by: Mashal Malik <107556986+Mashal-m@users.noreply.github.com>
Co-authored-by: Shafqat Farhan <shafqat.farhan@arbisoft.com>
Co-authored-by: Nawfal Ahmed <111358247+NawfalAhmed@users.noreply.github.com>
Co-authored-by: Nawfal Ahmed <nawfal.ahmed@arbisoft.com>
Co-authored-by: Muhammad Abdullah Waheed <42172960+abdullahwaheed@users.noreply.github.com>
Co-authored-by: edx-transifex-bot <edx-transifex-bot@users.noreply.github.com>
Co-authored-by: Jenkins <sre+jenkins@edx.org>
Co-authored-by: Muhammad Mattiullah <50130127+MuhammadMattiullah@users.noreply.github.com>
Co-authored-by: Shahroz Ahmad <97090106+ishahroz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants