Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Dead Code #434

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Removed Dead Code #434

wants to merge 2 commits into from

Conversation

manny-m
Copy link
Contributor

@manny-m manny-m commented Jan 24, 2022

Closes ENT-3342

Used npx unimported to find 10 files not being referenced in our app. These changes did not significantly change our bundle size.

There are still 5 files that are also not being imported by our app:

   1 │ src/__mocks__/reactResponsive.mock.js
   2 │ src/components/dashboard/main-content/course-enrollments/data/index.js
   3 │ src/components/skills-quiz/__mocks__/react-instantsearch-dom.jsx
   4 │ src/setupTest.js
   5 │ src/utils/tests.jsx

They were not removed because they are either mocks, test utilities, or used by 3rd party libraries.

Should consider adding some sort of linter to merge pipeline to catch these.

More about unimported here.

@manny-m manny-m changed the title fix: deleted unimported files Removed Dead Code Jan 24, 2022
@manny-m manny-m marked this pull request as ready for review January 24, 2022 20:39
@coveralls
Copy link

coveralls commented Jan 24, 2022

Pull Request Test Coverage Report for Build 1742046944

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 72.537%

Totals Coverage Status
Change from base Build 1740731794: 0.09%
Covered Lines: 1925
Relevant Lines: 2549

💛 - Coveralls


// This function is for filtering list of tags in a way that returning list
// can be displayed in the form of 2 rows at max.
const filterTags = tags => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file was edited recently but not used 🤔

@macdiesel
Copy link
Contributor

Since there is a lot of pathway stuff in this PR I would like to page @moconnell1453 to this PR. Could you have someone on your team take a look at this and verify these file are no longer needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants