Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: override react/prop-types rule for test files #589

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

long74100
Copy link
Contributor

@long74100 long74100 commented Jul 21, 2022

Override rule for test files so we don't have to disable it manually. Should consider moving this to base config in @edx/frontend-build

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant