-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add eslint role for no message description #460
Conversation
This uses an eslint role for getting strings with no descriptions, this for demonstration purpose and can be used for checking other MFEs or JS/React base repos Ref: openedx/wg-translations/issues/5 Related discussion: openedx/frontend-app-learning/pull/1143
Thanks for the pull request, @ghassanmas! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@ghassanmas Thanks for these changes! Aside from resolving some merge conflicts, it looks like they're ready for review? |
Hey @ghassanmas, just checking in to see if you're still planning to come back to this PR? |
Hi @ghassanmas! Just a quick update that we're closing this PR now because it seems to have become stale. You may reopen this pull request, or open a new one, when you have time to come back to this work. |
@ghassanmas Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
@itsjeyd I would be happy to continue wokring on resolving the conflicts, if there would a guarantee that this changes/ PR would be accepted at somepoint. This is just to avoid spending time on someting that might not be accepted. I think following openedx/frontend-app-learning#1143, @brian-smith-tcril might have a say on that. |
OSPR management note: See openedx/wg-translations#5 (comment) for latest status. (This PR is still blocked waiting for general confirmation about whether it has a chance of being accepted at some point.) CC @ehuthmacher |
I discussed this with the Axim team and we decided a change like this will need to include a plan for all the consumers of This will allow us to migrate applications that depend on I've created an issue laying out the high level plan #517 |
This uses an eslint role for getting strings with no
descriptions, this for demonstration purpose and can be used
for checking other MFEs or JS/React base repos
Ref: openedx/wg-translations/issues/5
Related discussion: openedx/frontend-app-learning/pull/1143