Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prequery search suggestions #371

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Jan 30, 2024

Description

We want to add a prequery suggestions to the learner portal using the bayesian average that was added to algolia. The idea being when the course search box is focused, we give a drop down box selection of suggested courses based on their review data.

Related PR in learner portal: #935

JIRA

Screen.Recording.2024-01-30.at.12.31.34.AM.mov

Merge checklist:

  • Evaluate how your changes will impact existing consumers (e.g., frontend-app-learner-portal-enterprise, frontend-app-admin-portal, and frontend-app-enterprise-public-catalog). Will consumers safely be able to upgrade to this change without any breaking changes?
  • Ensure your commit message follows the semantic-release conventional commit message format. If your changes include a breaking change, ensure your commit message is explicitly marked as a BREAKING CHANGE so the NPM package is released as such.
  • Once CI is passing, verify the package versions that Lerna will increment to in the Github Action CI workflow logs.
    • Note: This may be found in the "Preview Updated Versions (dry run)" step in the Github Action CI workflow logs.

Post merge:

  • Verify Lerna created a release commit (e.g., chore(release): publish) that incremented versions in relevant package.json and CHANGELOG files, and created Git tags for those versions.
  • Run the Publish from package.json Github Action workflow to publish these new package versions to NPM.
    • This may be triggered by clicking the "Run workflow" option for the master branch.
  • Verify the new package versions were published to NPM (i.e., npm view <package_name> versions --json).
    • Note: There may be a slight delay between when the workflow finished and when NPM reports the package version as being published. If it doesn't appear right away in the above command, try again in a few minutes.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (1541b86) 78.37% compared to head (39d4e06) 78.61%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
+ Coverage   78.37%   78.61%   +0.23%     
==========================================
  Files          34       34              
  Lines         666      692      +26     
  Branches      170      179       +9     
==========================================
+ Hits          522      544      +22     
- Misses        131      135       +4     
  Partials       13       13              
Files Coverage Δ
packages/catalog-search/src/SearchHeader.jsx 92.30% <ø> (ø)
...ckages/catalog-search/src/SearchSuggestionItem.jsx 100.00% <100.00%> (ø)
packages/catalog-search/src/SearchSuggestions.jsx 100.00% <100.00%> (ø)
packages/catalog-search/src/data/constants.js 92.85% <100.00%> (+0.26%) ⬆️
packages/catalog-search/src/SearchBox.jsx 88.88% <66.66%> (-5.76%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1541b86...39d4e06. Read the comment docs.

@katrinan029 katrinan029 marked this pull request as ready for review January 30, 2024 19:03
@katrinan029 katrinan029 requested a review from a team January 30, 2024 19:03
Copy link
Contributor

@alex-sheehan-edx alex-sheehan-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of thoughts, some suggestions/questions but otherwise looks good to me!

Copy link
Contributor

@kiram15 kiram15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except a couple nits! One question is with the "view all results" at the bottom, it doesn't seem to do much cause it just takes you back to the same query (instead of going to just courses for example) is this expected?

@katrinan029 katrinan029 merged commit 3651ee0 into master Feb 1, 2024
9 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-8194 branch February 1, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants