Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable prequery suggestions only for variant group #377

Merged
merged 1 commit into from Mar 5, 2024

Conversation

katrinan029
Copy link
Contributor

@katrinan029 katrinan029 commented Mar 1, 2024

Updated logic to ensure that prequery suggestions are only displayed for users in the variant group.

https://2u-internal.atlassian.net/browse/ENT-8559

Merge checklist:

  • Evaluate how your changes will impact existing consumers (e.g., frontend-app-learner-portal-enterprise, frontend-app-admin-portal, and frontend-app-enterprise-public-catalog). Will consumers safely be able to upgrade to this change without any breaking changes?
  • Ensure your commit message follows the semantic-release conventional commit message format. If your changes include a breaking change, ensure your commit message is explicitly marked as a BREAKING CHANGE so the NPM package is released as such.
  • Once CI is passing, verify the package versions that Lerna will increment to in the Github Action CI workflow logs.
    • Note: This may be found in the "Preview Updated Versions (dry run)" step in the Github Action CI workflow logs.

Post merge:

  • Verify Lerna created a release commit (e.g., chore(release): publish) that incremented versions in relevant package.json and CHANGELOG files, and created Git tags for those versions.
  • Run the Publish from package.json Github Action workflow to publish these new package versions to NPM.
    • This may be triggered by clicking the "Run workflow" option for the master branch.
  • Verify the new package versions were published to NPM (i.e., npm view <package_name> versions --json).
    • Note: There may be a slight delay between when the workflow finished and when NPM reports the package version as being published. If it doesn't appear right away in the above command, try again in a few minutes.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.67%. Comparing base (45d9db9) to head (a367ee1).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
+ Coverage   78.64%   78.67%   +0.03%     
==========================================
  Files          35       35              
  Lines         693      694       +1     
  Branches      176      177       +1     
==========================================
+ Hits          545      546       +1     
  Misses        135      135              
  Partials       13       13              
Files Coverage Δ
...atalog-search/src/PrequerySearchSuggestionItem.jsx 100.00% <100.00%> (ø)
packages/catalog-search/src/SearchBox.jsx 88.88% <ø> (ø)
packages/catalog-search/src/SearchHeader.jsx 92.30% <ø> (ø)
...ckages/catalog-search/src/SearchSuggestionItem.jsx 100.00% <100.00%> (ø)
packages/catalog-search/src/SearchSuggestions.jsx 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45d9db9...a367ee1. Read the comment docs.

@katrinan029 katrinan029 marked this pull request as ready for review March 1, 2024 21:16
@katrinan029 katrinan029 requested a review from a team March 1, 2024 21:16
Copy link
Contributor

@kiram15 kiram15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@katrinan029 katrinan029 merged commit fbee42a into master Mar 5, 2024
10 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-8559 branch March 5, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants