chore: fix double notification routing and segment callback #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,18 +29,28 @@ class PushNotificationsManager: NSObject { | |||
| private let deepLinkManager: DeepLinkManager | |||
| private let storage: CoreStorage | |||
| private let api: API | |||
| private let segemntService: SegmentAnalyticsService? | |||
There was a problem hiding this comment.
typo segemntService -> segmentService
Comment on lines
43
to
48
| public init(deepLinkManager: DeepLinkManager, | ||
| storage: CoreStorage, | ||
| api: API, | ||
| config: ConfigProtocol, | ||
| segmentService: SegmentAnalyticsService? | ||
| ) { |
There was a problem hiding this comment.
Suggested change
| public init(deepLinkManager: DeepLinkManager, | |
| storage: CoreStorage, | |
| api: API, | |
| config: ConfigProtocol, | |
| segmentService: SegmentAnalyticsService? | |
| ) { | |
| public init( | |
| deepLinkManager: DeepLinkManager, | |
| storage: CoreStorage, | |
| api: API, | |
| config: ConfigProtocol, | |
| segmentService: SegmentAnalyticsService? | |
| ) { |
OpenEdX/DI/AppAssembly.swift
Outdated
Comment on lines
180
to
181
| config: r.resolve(ConfigProtocol.self)!, | ||
| segmentService: r.resolve(SegmentAnalyticsService.self) |
There was a problem hiding this comment.
Could we use an Analytics abstraction and not rely on the Segment dependency here?
We are going to migrate all third-party services to plugins, and this dependency could make it harder.
rnr
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with push notifications.
Issue details: #472