[FC-0049] feat: Update permissions to remove object tags #188
Conversation
|
Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
openedx-webhooks
added
the
open-source-contribution
ChrisChV
changed the title
* chore: Bump version * fix: Issue with remove object tag permission
ChrisChV
force-pushed
the
chris/FAL-3720-permissions-to-remove-object-tag
branch
from
da67904
to
c791682
Compare
|
|
||
| This rule could be defined in other apps for proper permission checking. | ||
| """ | ||
| return True |
There was a problem hiding this comment.
Can you move this down below can_change_object_tag_objectid ? Also the default value shouldn't be True - the default value should be the same as can_change_object_tag_objectid, so just call that function and return the same value.
There was a problem hiding this comment.
@bradenmacdonald Updated here bf49f69
| @@ -874,7 +874,8 @@ def test_retrieve_object_tags_query_count(self): | |||
| Test how many queries are used when retrieving object tags and permissions | |||
| """ | |||
| expected_perm = True | |||
| object_id, sort_test_applied_result = self.prepare_for_sort_test(expected_perm) | |||
| expoected_remove_perm = False | |||
| object_id, sort_test_applied_result = self.prepare_for_sort_test(expoected_remove_perm) | |||
There was a problem hiding this comment.
Minor typo: expoected_remove_perm
|
@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
bradenmacdonald
deleted the
chris/FAL-3720-permissions-to-remove-object-tag
branch
Description
This updates rules to add
can_remove_object_tag_objectidto Objet tag viewsSupporting information
Testing instructions