-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FC-0049] feat: Update remove object-tag permission #34728
[FC-0049] feat: Update remove object-tag permission #34728
Conversation
Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
a0cb8b6
to
358f6fe
Compare
Looks good. I tested it. Will approve once we've done the version bump of openedx-learning. |
95bb9c6
to
ad38401
Compare
(just rebased this since the tests weren't green due to some GitHub CI bug) |
…ssion' into taxonomy-sandbox-20240508
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 @ChrisChV Its working well.
- I tested this: Followed testing instructions in [FC-0049] feat: Other Tags section added on tags drawer frontend-app-course-authoring#987
- I read through the code
-
I checked for accessibility issues -
Includes documentation
@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
* feat: Update remove object-tag permission * chore: Bump openedx-learning version
Description
can_remove_object_tag_objectid
ruleopenedx-learning
versionSupporting information
Testing instructions
Other information
openedx-learning version