-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(semantic-commit-linting): add semantic commit linting #77
Conversation
720a82d
to
9260f66
Compare
This is a valuable bit of automation, but IMO too heavyweight to run for every commit. Some developers (myself included) push up a lot of WIP stuff as they're working on it, just so others can see it or CI can run against it, and those commit messages are generally meaningless. Besides, people tend to get antsy when you prevent them from committing -- even the pre-commit linter annoys some folks. Why enforce conventional commit syntax when it doesn't have any deeper implications? The only commit message that really matters is the squash commit, right? What do you think about using the |
@arizzitano that all makes sense - I guess you could still commit using the |
e34376b
to
5c6b3a4
Compare
fix(package.json): change commit script chore(dependencies): add back package-lock.json added some packages updated package.json added prepare commit message git hook chore(scripts): update scripts chore(eslint): remove unused eslintignore value chore(eslintignore): remove unnecessary value chore(package-scripts): used old script name
5c6b3a4
to
5208744
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give this a try. If people find it too heavyweight we can always revert.
The
commitmsg
hook fails when you try and add a commit message viagit commit
that does not follow conventional commit convention