fix(find-dependencies): http->https redirections weren't followed #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feanil
requested changes
Aug 18, 2023
| @@ -119,6 +119,8 @@ def find_real_url(url: str) -> Optional[str]: | |||
| # I didn't know you could get 429 from https://github.com, but you can... | |||
| wait = int(resp.headers.get("Retry-After", 10)) | |||
| time.sleep(wait + 1) | |||
| elif resp.status_code in {301, 302}: | |||
There was a problem hiding this comment.
I think instead of doing this manually you should let requests handle it.
https://docs.python-requests.org/en/latest/user/quickstart/#redirection-and-history
This way you follow all the redirects in case things move multiple times.
There was a problem hiding this comment.
Yes, I'm just realizing this, and wondering why the default of allow_redirects=True isn't applying here.
There was a problem hiding this comment.
oh, because I used HEAD.
nedbat
force-pushed
the
nedbat/fix-find-dependencies
branch
from
4040308
to
8c44d96
Compare
feanil
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking for the repos, we weren't following redirects from http to https, and so missed a number of repos.
See updated results in openedx/wg-build-test-release#238