Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add command to dump data to clickhouse #594

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Conversation

Ian2012
Copy link
Contributor

@Ian2012 Ian2012 commented Feb 6, 2024

Description

This PR replaces the dump-courses-to-clickhouse with the dump-data-to-clickhouse command and upgrades the openedx-event-sink-clickhouse version to v1.1.0

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 6, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@itsjeyd itsjeyd added core contributor PR author is a Core Contributor (who may or may not have write access to this repo). blocked by other work PR cannot be finished until other work is complete labels Feb 8, 2024
@Ian2012 Ian2012 removed the blocked by other work PR cannot be finished until other work is complete label Feb 12, 2024
@Ian2012 Ian2012 requested a review from bmtcril February 12, 2024 18:25
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -65,7 +65,7 @@ jobs:
run: tutor local do importdemocourse
- name: Test commands
run: |
tutor local do dump-courses-to-clickhouse --options "--force"
tutor local do dump-data-to-clickhouse --options "--object course_overviews"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Ian2012 Ian2012 merged commit 0620d3c into main Feb 12, 2024
6 checks passed
@Ian2012 Ian2012 deleted the cag/dump-data-clickhouse branch February 12, 2024 18:55
@openedx-webhooks
Copy link

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants