feat: add support for the Learning MFE #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by adding awareness for the new page structure, when loaded inside the iframe, as opposed to the legacy rendering. While this was, and still remains, a bit of an ugly hack, we do need this (some?) level of specificity with the DOM selectors, to avoid grabbing the "shadow" elements that the old courseware system sticks on the page.
davidjoy
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by adding awareness for the new page structure,
when loaded inside the iframe, as opposed to the legacy rendering.
While this was, and still remains, a bit of an ugly hack,
we do need this (some?) level of specificity with the DOM selectors,
to avoid grabbing the "shadow" elements that the old courseware system
sticks on the page.