Drop py3.8 support | Replace pkg_resources lib with importlib.resources #350
+22
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farhan
added
the
blocked by other work
farhan
force-pushed
the
farhan/replace_pkg_resources
branch
4 times, most recently
from
161b260
to
745e14c
Compare
farhan
requested review from
kdmccormick,
feanil,
salman2013,
irtazaakram and
a team
|
@farhan I think as a part of this PR, we should remove testing for Python 3.8 right? since that will fail to have the importlib module that you're using? As a part of that we should also update the classifiers and do a major version bump. |
farhan
force-pushed
the
farhan/replace_pkg_resources
branch
2 times, most recently
from
0dd0900
to
061ffc3
Compare
farhan
changed the title
farhan
force-pushed
the
farhan/replace_pkg_resources
branch
from
061ffc3
to
2bc4b42
Compare
farhan
changed the title
kdmccormick
reviewed
Jun 18, 2024
Co-authored-by: Kyle McCormick <kyle@kylemccormick.me>
farhan
force-pushed
the
farhan/replace_pkg_resources
branch
from
cdd51da
to
bbbffde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: openedx/XBlock#676
PR is expected to merge after Open edX redwood release
Followed migration guide: https://importlib-resources.readthedocs.io/en/latest/migration.html
Testing:
I have tested the changes with following steps:
xblock-sdkxblockintoxblock-sdkfeedback-xblockfrom PR intoxblock-sdk