-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop py3.8 support | Replace pkg_resources lib with importlib.resources #716
Conversation
cbf6745
to
79817df
Compare
6a467a8
to
7d95fd3
Compare
044638d
to
ec37198
Compare
fa5df5d
to
5f63a7d
Compare
ad54839
to
b29b815
Compare
This looks good, but we're currently blocked on merging and releasing this because we have not yet dropped 3.8 support in edx-platform. So let's hold off on merging for now. |
PR is blocked as we are waiting for drop of Python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Just a couple change requests. Glad to hear you tested this with xblock-sdk. I'm going to test this with edx-platform today or tomorrow, I'll let you know if I run into any issues.
d980494
to
d55a025
Compare
@kdmccormick |
I tried this branch of XBlock in Tutor Nightly with the latest edx-platform master and the
The resource is added to the LTI block on this line. |
d55a025
to
20de95c
Compare
@kdmccormick Thanks for the testing of this important PR. I have fixed the issues in this comment and tested on edx-platform PR is ready for next pass. Can you share some example course having different XBlocks on the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more comments, but this is getting close. The Python packaging APIs drive me nuts... I appreciate you guys digging into this.
@kdmccormick Thanks for such a quality review. Let me spend more time on it in depth |
44698d0
to
20149cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two small comments, but if you like these, then this looks good to me! Thanks for your thorough work here.
I tested with the ProblemBlock, drag-and-drop-v2, and lti_consumer blocks. (Since you asked, the best course I know of for testing different XBlocks is the openedx-test-course. It's not great, but it's better than nothing :)
05cee82
to
08627b0
Compare
08627b0
to
8885b94
Compare
Ticket: #676
Followed migration guide:
https://importlib-resources.readthedocs.io/en/latest/migration.html
Testing:
I have tested the changes with following steps:
Use PR of
xblock-sdk
Install
xblock
intoxblock-sdk
Install
feedback-xblock
from PR intoxblock-sdk
Test feedback xblock functionality