Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop py3.8 support | Replace pkg_resources lib with importlib.resources #716

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Drop py3.8 support | Replace pkg_resources lib with importlib.resources #716

wants to merge 2 commits into from

Conversation

farhan
Copy link
Contributor

@farhan farhan commented Feb 6, 2024 •
edited

  • Drop Py3.8 support
  • Replace pkg_resources lib with importlib.resources

Ticket: #676

Followed migration guide: https://importlib-resources.readthedocs.io/en/latest/migration.html

Testing:
I have tested the changes with following steps:

  1. Use PR of xblock-sdk
  2. Install xblock into xblock-sdk
  3. Install feedback-xblock from PR into xblock-sdk
  4. Test feedback xblock functionality

@farhan farhan linked an issue Feb 10, 2024 that may be closed by this pull request
Switch off of deprecated pkg_resources library #676
Open
@farhan farhan force-pushed the farhan/replace_pkg_resources branch 2 times, most recently from cbf6745 to 79817df Compare February 12, 2024 13:26
@farhan farhan marked this pull request as ready for review February 13, 2024 05:03
@kdmccormick
Copy link
Member

kdmccormick commented Feb 13, 2024 •
edited

@farhan per the conversation on #676, could we convert this to a draft and pause it until after the Python 3.11/3.12 upgrade? That would allow us to avoid adding importlib_resources as a dependency, because the new importlib.resources API becomes part of the standard library in 3.11.

@farhan farhan marked this pull request as draft February 14, 2024 08:20
@kdmccormick kdmccormick removed their request for review May 8, 2024 13:13
@farhan farhan force-pushed the farhan/replace_pkg_resources branch 5 times, most recently from 6a467a8 to 7d95fd3 Compare May 20, 2024 12:42
@farhan farhan closed this May 20, 2024
@farhan farhan reopened this May 20, 2024
@farhan farhan force-pushed the farhan/replace_pkg_resources branch 5 times, most recently from 044638d to ec37198 Compare May 20, 2024 15:42
@farhan farhan marked this pull request as ready for review May 22, 2024 06:01
@farhan farhan force-pushed the farhan/replace_pkg_resources branch from fa5df5d to 5f63a7d Compare May 23, 2024 07:34
@farhan farhan requested review from kdmccormick, feanil, irtazaakram and a team May 23, 2024 07:38
@farhan farhan force-pushed the farhan/replace_pkg_resources branch 3 times, most recently from ad54839 to b29b815 Compare May 30, 2024 07:11
@farhan farhan force-pushed the farhan/replace_pkg_resources branch from b29b815 to db47456 Compare May 30, 2024 07:20
@farhan farhan force-pushed the farhan/replace_pkg_resources branch from db47456 to e7bd7d8 Compare May 30, 2024 07:21
@farhan farhan changed the title Switch off of deprecated pkg_resources library Drop Py3.8 support | Replace pkg_resources lib with importlib.resources May 30, 2024
@farhan farhan force-pushed the farhan/replace_pkg_resources branch from e7bd7d8 to 231ee7f Compare May 30, 2024 07:30
@farhan farhan changed the title Drop Py3.8 support | Replace pkg_resources lib with importlib.resources Drop py3.8 support | Replace pkg_resources lib with importlib.resources May 30, 2024
@feanil
Copy link
Contributor

feanil commented Jun 7, 2024

This looks good, but we're currently blocked on merging and releasing this because we have not yet dropped 3.8 support in edx-platform. So let's hold off on merging for now.

@farhan
Copy link
Contributor Author

farhan commented Jun 10, 2024

PR is blocked as we are waiting for drop of Python v3.8 support from edx-platform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salman2013 salman2013 Awaiting requested review from salman2013

@kdmccormick kdmccormick Awaiting requested review from kdmccormick

@feanil feanil Awaiting requested review from feanil

@irtazaakram irtazaakram Awaiting requested review from irtazaakram

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch off of deprecated pkg_resources library
3 participants
@farhan @kdmccormick @feanil