Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install_requires and add installation of grader_support package #82

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

TheVinhLuong102
Copy link
Contributor

Hi authors, we've made some small fixes to the setup.py script for your consideration.

Thank you very much!

… text), and add installation of grader_support package
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 20, 2022
@openedx-webhooks
Copy link

openedx-webhooks commented Aug 20, 2022

Thanks for the pull request, @TheVinhLuong102! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@natabene
Copy link

@TheVinhLuong102 Thank you for the contribution. Once your CLA form have been processed, I will update here and we will be able to review your code.

@natabene natabene changed the title Fix install_requires and add installation of grader_support package Fix install_requires and add installation of grader_support package Aug 23, 2022
@natabene natabene changed the title Fix install_requires and add installation of grader_support package Fix install_requires and add installation of grader_support package Aug 23, 2022
@TheVinhLuong102
Copy link
Contributor Author

@natabene thank you so much!

I'm contributing on the behalf of STEAM for Vietnam Foundation, an educational non-profit org who is actively using and extending Open edX. We would like to submit regular enhancements and fixes for your review.

I've received and signed the DocuSign from Eden Huthmacher. Looking forward to formally collaborating with you. :)

Vinh

@natabene
Copy link

@TheVinhLuong102 Thank you for signing! Just to verify, you signed an entity agreement, not an individual one, correct?
Once it has been processed, you will be added to our records and we will be able to review your code.

@TheVinhLuong102
Copy link
Contributor Author

@natabene actually I received the "TCRIL Individual Contributor License Agreement" doc instead. Am I supposed to sign a different one? Could you guide me through? Thank you Natalia!

@natabene
Copy link

natabene commented Aug 26, 2022

@TheVinhLuong102 Yes, if you are contributing on behalf of any organization, please email to oscm@tcril.org and ask them for instructions. Also please mentioned that you signed an individual form accidentally.

@natabene natabene changed the title Fix install_requires and add installation of grader_support package Fix install_requires and add installation of grader_support package Sep 1, 2022
@natabene natabene changed the title Fix install_requires and add installation of grader_support package Fix install_requires and add installation of grader_support package Sep 1, 2022
@natabene
Copy link

natabene commented Sep 1, 2022

@TheVinhLuong102 Just checking if you had any luck with getting entity agreement signed?

@natabene natabene changed the title Fix install_requires and add installation of grader_support package Fix install_requires and add installation of grader_support package Sep 23, 2022
@natabene natabene changed the title Fix install_requires and add installation of grader_support package Fix install_requires and add installation of grader_support package Sep 23, 2022
@natabene
Copy link

The CLA check is green, wonderful. This can be reviewed by our teams.

@ProductRyan
Copy link

Creating a JIRA ticket for internal tracking:
https://2u-internal.atlassian.net/browse/AU-942

@mattcarter mattcarter self-assigned this Dec 5, 2022
@itsjeyd
Copy link

itsjeyd commented Jan 17, 2023

Hi @ProductRyan and @mattcarter, just checking in to see if you had a chance to schedule https://2u-internal.atlassian.net/browse/AU-942 yet?

Copy link

@mattcarter mattcarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

@mattcarter mattcarter merged commit ddf795b into openedx:master Feb 1, 2023
@openedx-webhooks
Copy link

@TheVinhLuong102 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd
Copy link

itsjeyd commented Feb 8, 2023

Thanks @mattcarter!

@TheVinhLuong102
Copy link
Contributor Author

Thank you so much @itsjeyd @mattcarter @ProductRyan @natabene et al.!

I'll work with my colleagues at STEAM for Vietnam and open a couple more PRs. :)

@itsjeyd
Copy link

itsjeyd commented Feb 17, 2023

That sounds great @TheVinhLuong102! Looking forward to future contributions from you and your team.

@TheVinhLuong102 TheVinhLuong102 deleted the update-setup-script branch February 18, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants