feat: scaffolded getting started screen #1
Conversation
There was a problem hiding this comment.
Hi, thanks for your PR! I've made a couple comments regarding it.
I generally recommend running the prettier formatter on the code, that'll fix the formatting.
Generally, the way I wrote the original code I had functions in mind rather than arrow functions. For consistency's sake, it may be best for us to all use functions rather than arrow functions. Also, since we're using TypeScript for this repository, please use interfaces to define your props. Thanks again!
| iconLaptop: IconLaptop, | ||
| }; | ||
|
|
||
| const SVGIcon = ({ type, ...props }) => { |
There was a problem hiding this comment.
Please use interfaces. I suggest creating an interface that extends whatever interface the props of SVGIcon uses. Also, ideally we'd use a different name for the SVGIcon variable and component.
There was a problem hiding this comment.
Got it! What is a good name instead of SVGIcon?
| </View> | ||
| ); | ||
|
|
||
| const renderItem = ({ item }) => ( |
There was a problem hiding this comment.
Same as previous comment. Please use interfaces.
To Do: