Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Ding0 v0.1.4 #242

Closed
15 tasks done
gplssm opened this issue Jan 9, 2018 · 6 comments
Closed
15 tasks done

Release Ding0 v0.1.4 #242

gplssm opened this issue Jan 9, 2018 · 6 comments
Assignees
Milestone

Comments

@gplssm
Copy link
Contributor

gplssm commented Jan 9, 2018

This release primarily focuses on providing updated dependencies. In particular, the versions of ego.io and PyPSA are updated.

Tasks

  • Move issues one version forward (0.1.3 -> 0.1.5, 0.1.4 -> 0.1.6) v0.1.4 is the current version to be released
  • Clarify if changes in "features/adapt-to-powerplant-mviews-dp-v0.3.0" includes important changes besides temporary new DP v0.3.0 tables
  • Update "What's new" with changes since v0.1.3
  • Create a results comparison framework to compare results after changes (on ego.io upgrad, PyPSA upgrade)
  • Upgrade to PyPSA v0.11.0 (check results!!)
  • Upgrade to new ego.io v0.3.0 (check results!!). Use a dependency link if release is not already available
  • Adjust SQL queries in order to retrieve DP v0.3.0 data from the MVIEWS supply: use new mviews instead of table for status quo scenario #225
  • Strictly use ego.io's connection provider instead of oemof.db Replace connection from oemof.db to ego.io and remove oemof.db from dependecy list #241
  • Remove oemof.db from dependency list
  • Align Pandas version with other packages: Pandas v0.20.3
  • Update docs about how-to-use Extend how-to-use in docs #244
  • Check if example works Check if example is up-to-date #243
  • Update "What's new"
  • Update version in setup.py to 0.1.4
  • Test if installation work in fresh environment
@gplssm gplssm self-assigned this Jan 9, 2018
@gplssm
Copy link
Contributor Author

gplssm commented Jan 9, 2018

Don't merge "features/adapt-to-powerplant-mviews-dp-v0.3.0". Just take changes in

  • ding0/config/config_calc.cfg
  • ding0/config/config_db_tables.cfg
  • ding0/core/init.py (in case we really access MVIEWS)

@gplssm gplssm added this to the Release 0.1.4 milestone Jan 10, 2018
@gplssm
Copy link
Contributor Author

gplssm commented Jan 10, 2018

For linking to ego.io via GitHub commit use

'egoio==0.3.0+git.a1208ae',

and

dependency_links=['https://github.com/openego/ego.io/archive/a1208aeffb57e16f49007f86b144ab6d576cbd0d.zip#egg=egoio-0.3.0+git.a1208ae'],

@gplssm
Copy link
Contributor Author

gplssm commented Jan 12, 2018

Framework for comparison
I used run_ding0 to generate a set of grid district data for comparison (20 representative grid districts determined by @abokam). Afterwards a comparison script compares nodes and edges of the graph.

@gplssm
Copy link
Contributor Author

gplssm commented Jan 12, 2018

PyPSA upgrade
Data generated by using PyPSA v0.10.0 and PyPSA v0.11.0 seems to be equal. Different branch IDs may be a result of branch setting in Ding0...

(3196, True, 'Data sets are identical.')
(3040, True, 'Data sets are identical.')
(274, False, 'Same number of branches with different IDs')
(1977, True, 'Data sets are identical.')
(2682, True, 'Data sets are identical.')
(2882, True, 'Data sets are identical.')
(1476, True, 'Data sets are identical.')
(1426, False, 'Same number of branches with different IDs')
(294, False, 'Same number of branches with different IDs')
(2490, True, 'Data sets are identical.')
(525, True, 'Data sets are identical.')
(1147, True, 'Data sets are identical.')
(239, False, 'Same number of branches with different IDs')
(3230, False, 'Same number of branches with different IDs')
(1103, True, 'Data sets are identical.')
(1364, True, 'Data sets are identical.')
(2035, True, 'Data sets are identical.')
(3021, False, 'Same number of branches with different IDs')

Update
Same behavior happens as well when two datasets created by exactly the same code is compared. Thus, either
(a) Ding0 does not perform deterministic
(b) The comparison function does not act correct.

I checked, both, the comparison function and set_branch_ids() use the same generator to iterate over edges.

The issue regarding the IDs is postponed #245

@gplssm
Copy link
Contributor Author

gplssm commented Jan 14, 2018

Works so far, but not entirely finished

  1. newly introduced .connect() could be remved if ego.io is changed Remove .connect() at engines #247
  2. ego.io dependency link should be removed prior to release. Otherwise ding0 must be installled with --process-dependency-links
  3. The comparison function does not work perfectly Comparison of identical Ding0 data does not always confirm equality #245 which is gently ignored right now
  4. scipy<1.0 was added to install_requires in order to override version >=1.0 installed by PyPSA Remove scipy from dependency list #246

Resolve at least 2. preferably including 1.

@gplssm
Copy link
Contributor Author

gplssm commented Jan 17, 2018

Update on the latest list of TODOs

  1. This is outdated since ding0 now use a session that is passed around 0f61ea3
  2. Is update by 1cc155f
  3. No update
  4. We'll keep scipy as dependency because pain in other related packages to upgrade to PyPSA v0.12.0 would much harder

@gplssm gplssm closed this as completed Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant