Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison of identical Ding0 data does not always confirm equality #245

Closed
3 tasks
gplssm opened this issue Jan 13, 2018 · 2 comments
Closed
3 tasks

Comparison of identical Ding0 data does not always confirm equality #245

gplssm opened this issue Jan 13, 2018 · 2 comments
Labels
bug Prio1 Priority Level 1
Milestone

Comments

@gplssm
Copy link
Contributor

gplssm commented Jan 13, 2018

The function for comparison of Ding0 networks sometimes state branch IDs aren't the same.
This can be reproduced by comparing 5-20 datasets generated by exactly the same Ding0 code and input data. The result is like this. The grid is most probably identical, but for some reason the IDs do not match.

Hints

Tasks

  • Make sure Ding0 is deterministic regarding IDs of branches
  • Revise comparison function to detect equality properly
  • Maybe comparison function such that it always returns more information about inequality
@gplssm gplssm added the bug label Jan 13, 2018
@gplssm gplssm added this to the Release 0.1.5 milestone Jan 13, 2018
@gplssm gplssm mentioned this issue Jan 13, 2018
15 tasks
@nesnoj
Copy link
Member

nesnoj commented Jan 15, 2018

According to #97, this was not completely solved. Refer to #40 (comment) for further details and proposed investigations.

@boltbeard boltbeard added the Prio1 Priority Level 1 label Jan 15, 2019
gplssm pushed a commit that referenced this issue Jul 25, 2019
* Change of table LV transformer

* fix in assignment of loads to generators to make it a deterministic procedure

* Revert "Change of table LV transformer"

This reverts commit 639bed2

* Update v0-1-11.rst

* Update v0-1-11.rst

* Update v0-1-11.rst

* Update v0-1-11.rst

* Update v0-1-11.rst
@mltja
Copy link
Member

mltja commented Mar 3, 2023

Already fixed

@mltja mltja closed this as completed Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Prio1 Priority Level 1
Projects
None yet
Development

No branches or pull requests

4 participants