Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch ids are not deterministic #97

Closed
nesnoj opened this issue Dec 13, 2016 · 1 comment
Closed

branch ids are not deterministic #97

nesnoj opened this issue Dec 13, 2016 · 1 comment
Assignees
@nesnoj
Labels
bug
Milestone
Salt shaker

Comments

@nesnoj
Copy link
Member

nesnoj commented Dec 13, 2016

For different runs with same input data, branches will get different ids - this impedes debugging. Dive into set_branch_ids() to solve it, we need a new method in Grid class to obtain sorted edges (similar to graph_nodes_sorted()).

Issue is related to salt shaker in #40.
@nesnoj nesnoj added the bug label Dec 13, 2016
@nesnoj nesnoj self-assigned this Dec 13, 2016
nesnoj added a commit that referenced this issue Dec 15, 2016
@nesnoj
sort edges in Grid's graph_edges() method
07ed7a0 
related to #97
@nesnoj nesnoj mentioned this issue Dec 15, 2016
Closed
@nesnoj
Copy link
Member Author

nesnoj commented Dec 20, 2016

I dived quite deep into DINGO's salt but I have to leave this issue unresolved for now due to lack of time. It is definitely related to #98. Resume discussion about determination in main issue #40.

@nesnoj nesnoj mentioned this issue Dec 21, 2016
Closed
@nesnoj nesnoj added this to the Salt shaker milestone Dec 21, 2016
@nesnoj nesnoj closed this as completed Sep 5, 2017
@nesnoj nesnoj mentioned this issue Jan 15, 2018
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nesnoj nesnoj

Labels
bug
Projects
None yet
Milestone
Salt shaker
Development

No branches or pull requests
1 participant
@nesnoj