Update gas data documentation #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line only contains the word `node` which breaks the Python file and all other files trying to import it, because Python thinks that's an identifier and errors out, since the name isn't defined anywhere. It's probably just a copy paste error or a typo that snuck into the commit.
And a superfluous line that doesn't conform to `black`'s style. All done by running `black`.
Thanks to the fact that the expressions in f-strings are just Python code which is somewhat whitespace agnostic, one can insert line breaks and spaces after the opening and before the closing curly braces without changing the resulting string. Helps keep the line lengths below 80 characters.
gnn
approved these changes
Jul 19, 2023
| @@ -1498,17 +1516,19 @@ def calculate_ocgt_capacities(): | |||
| df_ocgt = df_ocgt.groupby(by=["bus0", "bus1"], as_index=False).sum() | |||
|
|
|||
| return df_ocgt | |||
|
|
|||
| node | |||
There was a problem hiding this comment.
That tiny node was what broke the tests. :) Fixed in 8146d92. ;)
There was a problem hiding this comment.
Thanks for fixing :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed typos, added some missing function documentations
Before merging into
dev-branch, please make sure thatCHANGELOG.rstwas updated.blackandisort.Dataset-version is updated when existing datasets are adjusted.continuous-integration/run-everything-over-the-weekend-branch.test mode.Everythingmode.