Fix #193 #194
Merged
Fix #193 #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `uri` is only a constructor parameter and not actually an attribute of `Connection` objects, setting it doesn't seem to do anything, which might be the reason for `PostgresOperator`s not picking up connection parameters, leading to #193. Note that `Connection`s don't have an attribute for the database name, but from testing it out, it seems that the database name is stored in the `schema` attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not much to it. Figured out the reason for the bug and hopefully fixed it. Could you check whether #193 is actually gone on this branch, @ulfmueller?