Skip to content

Commit

Permalink
wic: use kernel_dir instead of bootimg_dir
Browse files Browse the repository at this point in the history
bootimg_dir is usually set to the value of STAGING_DATADIR and
kernel_dir - to the value of DEPLOY_DIR_IMAGE, so usage of
kernel_dir is more logical in bootimg-efi, bootimg-partition and
rawcopy plugins.

Replaced usage of bootimg_dir to kernel_dir in 3 above mentioned
plugins that use DEPLOY_DIR_IMAGE as a default artifact location.

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
  • Loading branch information
Ed Bartosh authored and rpurdie committed Mar 22, 2017
1 parent 2457ea5 commit 48a5d67
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 18 deletions.
14 changes: 7 additions & 7 deletions scripts/lib/wic/plugins/source/bootimg-efi.py
Expand Up @@ -185,9 +185,9 @@ def do_prepare_partition(cls, part, source_params, creator, cr_workdir,
'prepares' the partition to be incorporated into the image.
In this case, prepare content for an EFI (grub) boot partition.
"""
if not bootimg_dir:
bootimg_dir = get_bitbake_var("DEPLOY_DIR_IMAGE")
if not bootimg_dir:
if not kernel_dir:
kernel_dir = get_bitbake_var("DEPLOY_DIR_IMAGE")
if not kernel_dir:
raise WicError("Couldn't find DEPLOY_DIR_IMAGE, exiting")

staging_kernel_dir = kernel_dir
Expand All @@ -203,22 +203,22 @@ def do_prepare_partition(cls, part, source_params, creator, cr_workdir,
if source_params['loader'] == 'grub-efi':
shutil.copyfile("%s/hdd/boot/EFI/BOOT/grub.cfg" % cr_workdir,
"%s/grub.cfg" % cr_workdir)
for mod in [x for x in os.listdir(bootimg_dir) if x.startswith("grub-efi-")]:
cp_cmd = "cp %s/%s %s/EFI/BOOT/%s" % (bootimg_dir, mod, hdddir, mod[9:])
for mod in [x for x in os.listdir(kernel_dir) if x.startswith("grub-efi-")]:
cp_cmd = "cp %s/%s %s/EFI/BOOT/%s" % (kernel_dir, mod, hdddir, mod[9:])
exec_cmd(cp_cmd, True)
shutil.move("%s/grub.cfg" % cr_workdir,
"%s/hdd/boot/EFI/BOOT/grub.cfg" % cr_workdir)
elif source_params['loader'] == 'systemd-boot':
for mod in [x for x in os.listdir(bootimg_dir) if x.startswith("systemd-")]:
cp_cmd = "cp %s/%s %s/EFI/BOOT/%s" % (bootimg_dir, mod, hdddir, mod[8:])
cp_cmd = "cp %s/%s %s/EFI/BOOT/%s" % (kernel_dir, mod, hdddir, mod[8:])
exec_cmd(cp_cmd, True)
else:
raise WicError("unrecognized bootimg-efi loader: %s" %
source_params['loader'])
except KeyError:
raise WicError("bootimg-efi requires a loader, none specified")

startup = os.path.join(bootimg_dir, "startup.nsh")
startup = os.path.join(kernel_dir, "startup.nsh")
if os.path.exists(startup):
cp_cmd = "cp %s %s/" % (startup, hdddir)
exec_cmd(cp_cmd, True)
Expand Down
12 changes: 6 additions & 6 deletions scripts/lib/wic/plugins/source/bootimg-partition.py
Expand Up @@ -78,12 +78,12 @@ def do_prepare_partition(cls, part, source_params, cr, cr_workdir,
install_cmd = "install -d %s" % hdddir
exec_cmd(install_cmd)

if not bootimg_dir:
bootimg_dir = get_bitbake_var("DEPLOY_DIR_IMAGE")
if not bootimg_dir:
if not kernel_dir:
kernel_dir = get_bitbake_var("DEPLOY_DIR_IMAGE")
if not kernel_dir:
raise WicError("Couldn't find DEPLOY_DIR_IMAGE, exiting")

logger.debug('Bootimg dir: %s', bootimg_dir)
logger.debug('Kernel dir: %s', bootimg_dir)

boot_files = get_bitbake_var("IMAGE_BOOT_FILES")

Expand Down Expand Up @@ -118,7 +118,7 @@ def do_prepare_partition(cls, part, source_params, cr, cr_workdir,
os.path.join(dst,
os.path.basename(name))

srcs = glob(os.path.join(bootimg_dir, src))
srcs = glob(os.path.join(kernel_dir, src))

logger.debug('Globbed sources: %s', ', '.join(srcs))
for entry in srcs:
Expand All @@ -127,7 +127,7 @@ def do_prepare_partition(cls, part, source_params, cr, cr_workdir,
os.path.join(hdddir,
entry_dst_name)))
else:
install_task = [(os.path.join(bootimg_dir, src),
install_task = [(os.path.join(kernel_dir, src),
os.path.join(hdddir, dst))]

for task in install_task:
Expand Down
10 changes: 5 additions & 5 deletions scripts/lib/wic/plugins/source/rawcopy.py
Expand Up @@ -59,17 +59,17 @@ def do_prepare_partition(cls, part, source_params, cr, cr_workdir,
Called to do the actual content population for a partition i.e. it
'prepares' the partition to be incorporated into the image.
"""
if not bootimg_dir:
bootimg_dir = get_bitbake_var("DEPLOY_DIR_IMAGE")
if not bootimg_dir:
if not kernel_dir:
kernel_dir = get_bitbake_var("DEPLOY_DIR_IMAGE")
if not kernel_dir:
raise WicError("Couldn't find DEPLOY_DIR_IMAGE, exiting")

logger.debug('Bootimg dir: %s', bootimg_dir)
logger.debug('Kernel dir: %s', kernel_dir)

if 'file' not in source_params:
raise WicError("No file specified")

src = os.path.join(bootimg_dir, source_params['file'])
src = os.path.join(kernel_dir, source_params['file'])
dst = os.path.join(cr_workdir, "%s.%s" % (source_params['file'], part.lineno))

if 'skip' in source_params:
Expand Down

0 comments on commit 48a5d67

Please sign in to comment.