Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clinical reminders bug when no actions in active alert summary function #2834

Closed
stephenwaite opened this issue Dec 8, 2019 · 1 comment
Closed

Comments

@stephenwaite
Copy link
Sponsor Member

hi @bradymiller , looking over @ophthal 's recent questions regarding clinical reminders led me to this script

which led me to https://www.php.net/manual/en/function.session-write-close.php#112681

what if the ajax request isn't completed because of a rather large database of clinical reminders related table and somehow another process starts that goes to set the new patient id, then the session variables won't get updated right?

for debugging could we just comment out the session_write_close where it occurs in the patient_reminders_fragment and clinical_reminders_fragment and see if that helps?

related forum post

@stephenwaite
Copy link
Sponsor Member Author

stephenwaite commented Dec 8, 2019

trying to error_log my way to debug and came across situation where if one patient has no clinical reminders it will not reset the alert_notify_pid so when you go back to the former patient it thinks it hasn't left so clinical reminders are not triggered

so when there are no actions we have to update the code with

        $_SESSION['alert_notify_pid'] = $pid;

in the active_alert_summary function

@stephenwaite stephenwaite changed the title session_write_close, fragments and bad session data clinical reminders bug when no actions in active alert summary function Dec 8, 2019
stephenwaite added a commit to stephenwaite/openemr that referenced this issue Dec 19, 2019
stephenwaite added a commit that referenced this issue Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant