Fix #3002 change encounter tabs to bootstrap style #3039
Conversation
|
hi @stu01509 , Code looks good. Now the more difficult part. Those tabs at the top are based on jquery-ui using this class: The goal is to remove the dependence on those jquery-ui libraries inside TabsWrapper.php. Sorry, I should of been more clear. I didn't realize it was all hidden away in that TabsWrapper.php class. -brady |
| } | ||
| $StringEcho .= "<li class=\"encounter-form-category-li\"><a href='JavaScript:void(0);' onClick=\"mopen(" . attr_js($DivId) . ");\" >" . text($new_category) . "</a><div id='" . attr($DivId) . "' ><table border='0' cellspacing='0' cellpadding='0'>"; | ||
| $StringEcho .= "<div class='dropdown d-inline'><button class='btn btn-secondary dropdown-toggle' type='button' id='menu" . text($new_category) . "' data-toggle='dropdown' aria-haspopup='true' aria-expanded='false'>" .text($new_category) . "</button>"; |
There was a problem hiding this comment.
The fist $new_category on above line should be wrapped in the attr() function (rather than text() function) since it's within html attribute. The text/attr are html escaping functions and are basically shortcuts for htmlspecialchar/ENT_NOQUOTES and htmlspecialchars/ENT_QUOTES respectively.
So I need to remove jquery-UI from TabsWrapper.php? |
|
hi @stu01509 , Sounds good. This is testing nicely. Will bring this in and start another issue for TabsWrapper.php. Thanks for the code improvement! -brady |
|
lol, just hit me. still gotta fix psr2 issue and the attr() . I'm gonna do that real quick in followup commit to keep travis happy :) |
Fixes #3002
Short description of what this resolves:
Change encounter tabs to bootstrap style
