Fix#3005 : Remove EDI History jquery ui

[stu01509]

Fixes #3005

Short description of what this resolves:

Remove EDI History jquery ui

[stu01509]

Hello @bradymiller @stephenwaite @tywrenn

Do you have any ideas or suggestions about these sections? Especially the table seems like used jquery data tables-UI.

[tywrenn]

@stu01509 I attempted to fix this up in my pull request that is now basically dead, #2927. If you use some of what I used in cleaning it up that might help you out.

[stu01509]

Hello @bradymiller @stephenwaite @tywrenn

Finally, It looks better than jquery UI pretty. I also remove datatales-jq to datatables-bs,
Please review it, Thanks :)

[bradymiller]

rec dropping the no_main-theme and seeing what happens

[bradymiller]

prob also need this token in there datatables-dt, which is generally needed whenever using datatables-bs

[stu01509]

Hi @bradymiller sir

I removed the no_main-theme, and it seems like to apply your custom style. e.g. button color.
Any suggestions or feedback?

[bradymiller]

hi @stu01509 , Overall gui appears to look good.

Noted following error in console when opened tab:

Also noted following error in console at Notes->Open (enter note) -> Save

After get those errors sorted out, I think @stephenwaite may be able to test it out.

[stu01509]

Hi @bradymiller sir

Thanks for your review, I updated the commit, please review it again 😃.

[bradymiller]

hi @stu01509 , Looks like getting close. Noted this js error at EDI File->Submit:

[stu01509]

Hello @bradymiller

Updated the commit :)

[stephenwaite]

hi @stu01509 , looks like there's a little issue with the edi file

[stu01509]

Hello @stephenwaite

Thanks for your review, can you give the test file?
I will try to do completely testing :)

[stephenwaite]

sure, it's attached, thanks @stu01509
EDI_837_5010_Usecase1.txt

[stu01509]

Hello @stephenwaite

I reproduce in my environment, it seems good to work. I guess you deploy old commit version, because I already remove the all jquery-ui accordion. Please take look :)

[stephenwaite]

hi @stu01509 , what about round line 800 of interface/billing/edih_view.php?

[tywrenn]

@stu01509 Offending code:
$('#x12rsp > #accordion').accordion({

Line 800 to 806 in edih_view.php

[stu01509]

Hello @stephenwaite and @tywrenn

Thanks for your review and help, I updated the commit, please take look.
Thank you :)

[stu01509]

🏓 @stephenwaite

[stephenwaite]

hi @stu01509, am seeing

* e303d8786 - (HEAD, stu01509/fix-#3005-remove-jquery-ui) fix: remove unnecessary code (3 days ago) <Cliff Su>
* a4e3d4b15 - (fix-#3005-remove-jquery-ui) fix: jqeury syantax error (4 days ago) <Cliff Su>
* 0026ba715 - fix: remove no_main-theme and add datatables-dt (4 days ago) <Cliff Su>

as last 3 commits, did you push the update from 2 days ago? thank you

[stu01509]

Hi @stephenwaite

Yes, I fixed the accordion issue in e303d87 commit.

[stephenwaite]

ok, testing well, thank you @stu01509

[stu01509]

Thanks for your review and help 😁 @stephenwaite

[stephenwaite]

another openemr improvement from @stu01509 !

[sjpadgett]

Aww come on! now I have to go out and find me an animation!:)

[stephenwaite]

how about

[sjpadgett]

A little ho-hum for my big personality don't ya think?

[stephenwaite]

hope you're not a 🍀 fan

[im-Amitto]

@stu01509

[stu01509]

Let us say goodbye to outdated animation haha 😄😄