Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #3817: refine past encounters and documents. #3822

Merged
merged 4 commits into from
Aug 10, 2020

Conversation

stu01509
Copy link
Member

@stu01509 stu01509 commented Aug 6, 2020

Refine past encounters and documents.

Fixes #3817

Short description of what this resolves:

  • Remove outdated code and inline-style.
  • Add the bootstrap table button style.
  • Improve the billing note input form.
  • Fix the EOB Invoice form datapicker single quote and double quote error.

image

image

image

image

- Remove outdated code and inline-style.
- Add the bootstrap table button style.
- Imporve the billing note input form.
- Remove outdated code and inline-style.
- Fix the EOB Invoice form datapicker single quote and double quote error.
@@ -693,7 +691,8 @@ function updateFields(payField, adjField, balField, coPayField, isFirstProcCode)
<input name="form_line[<?php echo attr($code); ?>][pay]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Input needs to be closed here witth /> at the end

</form>
<div class="container">
<div class="row">
<div class="col-12">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need a row and col-12 here since the form is already naturally at 100% width.


<br />

<table class="table table-hover jumbotron py-4 mt-3">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs table-responsive added to the table

@stu01509
Copy link
Member Author

stu01509 commented Aug 9, 2020

Update the commit :)

@tywrenn
Copy link
Contributor

tywrenn commented Aug 10, 2020

@stu01509 Please rebase to master, there's a couchdb update that keeps messing up docker for me

EDIT: Never mind got it working

@tywrenn tywrenn self-requested a review August 10, 2020 00:50
Copy link
Contributor

@tywrenn tywrenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bradymiller
Copy link
Sponsor Member

hi @stu01509 and @tywrenn , bringing in. thanks for the improvements! -brady

@bradymiller bradymiller merged commit c83ddb4 into openemr:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Issue: Past Encounters and Documents Billing Note
3 participants