Enhancing Login Page Customizations and Twig Migration #4632
Conversation
|
Can test this PR on the Up For Grabs demo at: https://www.open-emr.org/wiki/index.php/Development_Demo#Delta_-_Up_For_Grabs_Demo |
|
Can confirm that these changes do not break the Google Sign-in process, I manually tested that and it still works |
|
looks great! super job @robertdown , thanks for the up for grabs demo site @bradymiller |
|
I’m going to add one more global option to show/hide the label fields for username and password. Plan to add in the next couple of days |
|
hi @robertdown , code review complete :) very nice stuff! |
|
I’m traveling for several days but will get this wrapped up in early October. |
|
hi @robertdown , just let us know when this is ready for review/testing |
Just need to fix the test fails |
|
@bradymiller All issues have been resolved, going to bring this in later today |
|
|
Changes proposed in this pull request:
This PR adds customization to the login page by creating 3 new global options in the Appearance section. First, a boolean that will hide the tagline. Second, a textbox to customize the tagline if you wanted (The default is now what the previously hard-coded text was). Third, a boolean that hides the Acknowledgement link. The defaults of these new settings match current state to minimize disruption.
The login.scss file was updated doing away with the gradient behind the logo and instead uses the primary theme color of the theme as defined by the bootstrap theme-colors map.
The entire login.php page was moved over to a Twig template to improve separation of business logic from display logic.
The labels on the username and password were hidden by default using
.sr-onlyas they already have a Placeholder attribute, effectively resulting in duplicate directions.The login icon was removed from the Login button.
below added by bradymiller
Can test this PR on the Up For Grabs demo at: https://www.open-emr.org/wiki/index.php/Development_Demo#Delta_-_Up_For_Grabs_Demo