Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test-build-config batch file for Windows builds #1002

Closed
johnkord opened this issue Oct 30, 2018 · 5 comments
Closed

Add a test-build-config batch file for Windows builds #1002

johnkord opened this issue Oct 30, 2018 · 5 comments
Assignees
@ionutbalutoiu @johnkord
Labels
build Issue is related to the build system engineering Issue is related to tools and processes necessary for maintaining the Open Enclave repo windows Issue has to do with supporting Open Enclave on Windows
Projects
v0.5x Cloudbase Work
Milestone
v0.5

Comments

@johnkord
Copy link
Contributor

No description provided.

@johnkord johnkord added the engineering Issue is related to tools and processes necessary for maintaining the Open Enclave repo label Oct 30, 2018
@johnkord johnkord self-assigned this Oct 30, 2018
@CodeMonkeyLeet CodeMonkeyLeet added the windows Issue has to do with supporting Open Enclave on Windows label Nov 6, 2018
@radhikaj radhikaj added the build Issue is related to the build system label Nov 6, 2018
@CodeMonkeyLeet CodeMonkeyLeet mentioned this issue Nov 7, 2018
Closed
4 tasks
@CodeMonkeyLeet CodeMonkeyLeet added this to To do in v0.5x via automation Nov 7, 2018
@CodeMonkeyLeet CodeMonkeyLeet moved this from To do to In progress in v0.5x Nov 7, 2018
@CodeMonkeyLeet CodeMonkeyLeet added this to the 2018.11 milestone Nov 7, 2018
@0dragosh 0dragosh mentioned this issue Nov 26, 2018
Merged
@0dragosh
Copy link
Contributor

@johnkord I created PR #1108 to solve this.

oe-bors bot pushed a commit that referenced this issue Nov 27, 2018
@oeciteam @0dragosh
Merge #1108
9eb541a 
1108: Added test-build-config.ps1 powershell script to address issue #1002 r=johnkord a=dragoshsch

- This PR addresses GitHub issue #1002 by porting [test-build-config]() to a Powershell script

- Jenkinsfile changes will be added in a new PR once [PR #1057](#1085) is merged.

Co-authored-by: Dragos S <39906742+dragoshsch@users.noreply.github.com>
@ionutbalutoiu
Copy link
Contributor

The PR #1108 merged. Closing this.

v0.5x automation moved this from In progress to Done Nov 27, 2018
@johnkord johnkord reopened this Dec 1, 2018
v0.5x automation moved this from Done to In progress Dec 1, 2018
@johnkord johnkord mentioned this issue Dec 1, 2018
Closed
@johnkord
Copy link
Contributor Author

johnkord commented Dec 1, 2018

As of #1143 this change was reverted. That PR reverted the Jenkinsfile back to the previous non-scripted version, and that doing so reverted this batch->powershell change. However,there was an issue that @CodeMonkeyLeet noticed this morning that originally led us down this path of investigation: https://oe-jenkins.eastus.cloudapp.azure.com/blue/organizations/jenkins/Bors/detail/staging/288/pipeline/32
failed powershell but success

Note that powershell isn't able to find the script it's trying to run and fails, but somehow Jenkins reports it as a successful step. I imagine it wasn't able to find the powershell script to run due to issue #1148 which seemed to somehow prevent git checkout/cleanup from working for the Windows stages.

@0dragosh
Copy link
Contributor

0dragosh commented Dec 4, 2018 •
edited
Loading

@johnkord This happens because an exit code isn't set automatically by the PowerShell plugin, so we solved this in PR #1150 by using a wrapper to call PowerShell commands, where we set exit codes correctly.

@CodeMonkeyLeet CodeMonkeyLeet modified the milestones: 2018.11, 2018.12 Dec 5, 2018
@johnkord
Copy link
Contributor Author

johnkord commented Jan 2, 2019

This should be resolved now as per #1150

@johnkord johnkord closed this as completed Jan 2, 2019
v0.5x automation moved this from In progress to Done Jan 2, 2019
@johnkord johnkord added this to To Do in Cloudbase Work via automation Jan 3, 2019
@johnkord johnkord moved this from To Do to Done in Cloudbase Work Jan 3, 2019
@andyleejordan andyleejordan modified the milestones: 2018.12, v0.5 Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ionutbalutoiu ionutbalutoiu

@johnkord johnkord

Labels
build Issue is related to the build system engineering Issue is related to tools and processes necessary for maintaining the Open Enclave repo windows Issue has to do with supporting Open Enclave on Windows
Projects
Cloudbase Work
  
Done
v0.5x
  
Done
Milestone
v0.5
Development

No branches or pull requests
6 participants
@andyleejordan @ionutbalutoiu @radhikaj @johnkord @CodeMonkeyLeet @0dragosh