Fixing Windows CI build. #1143
Merged
Fixing Windows CI build. #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnkord
added
the
ci/cd
|
Take a look at the build output here for the powershell script for the Windows stage: https://oe-jenkins.eastus.cloudapp.azure.com/blue/organizations/jenkins/Bors/detail/staging/289/pipeline/32 |
johnkord
force-pushed
the
johnkord-revert_windows_powershell_CI
branch
2 times, most recently
from
9c61a26
to
047fff9
Compare
|
bors try |
|
(The following comment is no longer valid to the current changes in this PR, but I'm leaving it around for historical purpsoses): Note that the extra commit here (deleting the "linuxbin" directory) is to get CI to pass on Windows. The Jenkins agent on Windows is not cleaning the Jenkins workspace before or after the build properly, even though it is configured to do so. That seems like a bug with the Jenkins agent. To remedy this, we now force remove the "linuxbin" directory before the build to make sure that it is wiped away. |
CodeMonkeyLeet
approved these changes
Nov 30, 2018
tryBuild failed |
|
Oh yeah, PowerShell doesn't usually report the exit code of native processes back to the process which spawned PowerShell. This bites everyone. |
|
You can do it in PowerShell, you just have to wrap the execution of the native binaries and instruct PowerShell to |
andyleejordan
approved these changes
Nov 30, 2018
johnkord
force-pushed
the
johnkord-revert_windows_powershell_CI
branch
from
047fff9
to
08ba23d
Compare
|
bors try |
tryBuild failed |
added 2 commits
November 30, 2018 16:31
Something is broken regarding the scripted Jenkinsfile and how it handles updates to the git repository and cleaning the workspace. On our Windows CI, very odd behavior has been seen.
These flags have been temporarily removed because Windows doesn't recognize them and our Windows CI has been broken for the last few days and ignoring builds that would otherwise fail.
johnkord
force-pushed
the
johnkord-revert_windows_powershell_CI
branch
from
08ba23d
to
e36ff75
Compare
|
bors try |
tryBuild failed |
|
bors try |
tryBuild failed |
johnkord
changed the title
johnkord
force-pushed
the
johnkord-revert_windows_powershell_CI
branch
from
e36ff75
to
42ef11e
Compare
|
bors try |
tryBuild succeeded |
|
bors r+ |
oe-bors bot
pushed a commit
that referenced
this pull request
Dec 1, 2018
1143: Fixing Windows CI build. r=johnkord a=johnkord Right now Windows builds in CI are broken (the tests aren't getting run and powershell is erroring out, yet it believes it to be a successful build), and this PR will revert the changes that broke it. This PR temporarily disables the oeedgr8r tests on Windows, which needs to be re-enabled ASAP. Co-authored-by: John Kordich <johnkord@microsoft.com> Co-authored-by: Anita Govindarajan <v-angovi@microsoft.com>
Build failed |
|
bors r+ |
oe-bors bot
pushed a commit
that referenced
this pull request
Dec 1, 2018
1143: Fixing Windows CI build. r=johnkord a=johnkord Right now Windows builds in CI are broken (the tests aren't getting run and powershell is erroring out, yet it believes it to be a successful build), and this PR will revert the changes that broke it. This PR temporarily disables the oeedgr8r tests on Windows, which needs to be re-enabled ASAP. Co-authored-by: John Kordich <johnkord@microsoft.com> Co-authored-by: Anita Govindarajan <v-angovi@microsoft.com>
Build failed |
|
bors r+ |
oe-bors bot
pushed a commit
that referenced
this pull request
Dec 1, 2018
1143: Fixing Windows CI build. r=johnkord a=johnkord Right now Windows builds in CI are broken (the tests aren't getting run and powershell is erroring out, yet it believes it to be a successful build), and this PR will revert the changes that broke it. This PR temporarily disables the oeedgr8r tests on Windows, which needs to be re-enabled ASAP. Co-authored-by: John Kordich <johnkord@microsoft.com> Co-authored-by: Anita Govindarajan <v-angovi@microsoft.com>
Build succeeded |
|
Woo hoo! :) |
|
Great job John. Windows CI giving a False PASS wasn't good. |
This was referenced Dec 1, 2018
oprinmarius
pushed a commit
to oprinmarius/openenclave
that referenced
this pull request
Dec 3, 2018
1143: Fixing Windows CI build. r=johnkord a=johnkord Right now Windows builds in CI are broken (the tests aren't getting run and powershell is erroring out, yet it believes it to be a successful build), and this PR will revert the changes that broke it. This PR temporarily disables the oeedgr8r tests on Windows, which needs to be re-enabled ASAP. Co-authored-by: John Kordich <johnkord@microsoft.com> Co-authored-by: Anita Govindarajan <v-angovi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now Windows builds in CI are broken (the tests aren't getting run and powershell is erroring out, yet it believes it to be a successful build), and this PR will revert the changes that broke it.
This PR temporarily disables the oeedgr8r tests on Windows, which needs to be re-enabled ASAP.