Ensure that oe_enclave_properties_sgx doesn't use GOT in globals.c #4473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows oe_enclave_properties_sgx to be used even before relocations have been done, just like _enclave_rva, _reloc_rva etc. Thus core api oe_is_within_enclave, oe_is_outside_enclave can be used anywhere in enclave code, even before relocations. To ensure that no GOT is used, a weak definition of oe_enclave_properties is defined in globals.c. This definition willl be put in .oeinfo section. If an enclave uses the OE_SET_ENCLAVE_SGX macro, then a strong definition will be emitted which will override the weak definition. Signed-off-by: Anand Krishnamoorthi <anakrish@microsoft.com>
anakrish
requested review from
mingweishih,
gupta-ak and
mikbras
as code owners
|
bors try |
mingweishih
approved these changes
Apr 21, 2022
anakrish
added
the
do not merge
tryBuild succeeded: |
radhikaj
approved these changes
Apr 22, 2022
|
bors try |
tryBuild failed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows oe_enclave_properties_sgx to be used even before
relocations have been done, just like _enclave_rva, _reloc_rva etc.
Thus core api oe_is_within_enclave, oe_is_outside_enclave can be used
anywhere in enclave code, even before relocations.
To ensure that no GOT is used, a weak definition of oe_enclave_properties is defined in
globals.c. This definition willl be put in .oeinfo section.
If an enclave uses the OE_SET_ENCLAVE_SGX macro, then a strong definition will be emitted
which will override the weak definition.
Signed-off-by: Anand Krishnamoorthi anakrish@microsoft.com